1209798 - Test that songs without a track number will display an empty index

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
Songs without a track number will display "undefined" and overlap the song names when viewing a playlist in the music app

Prerequisite:
Have songs without a track number set

Repro Steps:
1) Update a Aries to 20150929110451
2) Open the music app
3) Go to the album view
4) Open an album that contains songs that dont have a track number
5) Observe Track number

Actual:
Songs without a track number will display "undefined"

Expected:
It is expected that songs without a track number will not display anything in the track number section

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150929110451
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 10/10
See attached: Screenshot, logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Undefined overlap

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150929030205
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
Songs without a track number will display "undefined"

Comment 3

[Hubert Figuiere [:hub]]

As of now I get "NaN" instead of "undefined".

Comment 4

[Hubert Figuiere [:hub]]

Morphing to writing a test. Another bug deal with the issue (NaN)

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1209798-undefined-track-number > mozilla-b2g:master

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 8668234 [details] [review]
[gaia] hfiguiere:bug1209798-undefined-track-number > mozilla-b2g:master

Let's test this. On top of your patch.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/7d36bc547e8113a806d27f74df8e859eabe9a6e3

Comment 8

[Adam Alldredge [:AdamA][Inactive]]

This issue is verified fixed in Aries 2.5 and Flame 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20151001114357
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 2c1fb007137dcb68b1862a79553b53f1a34c99c3
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.5 [Full Flash]
BuildID: 20151001030229
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 096c0f407f8ba3ef7cfe4e0b831761993cac38b1
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
Songs with no track number set have a blank track number section.