Closed Bug 1209806 Opened 5 years ago Closed 5 years ago

Remove dependency on libavformat

Categories

(Core :: Audio/Video: Playback, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: jya, Unassigned)

References

Details

Attachments

(2 files)

When searching for ffmpeg or libav we currently look for libavformat and search a specific version.

We have no use for the libavformat library as we only use libavcodec and indirectly libavutil.

The version numbering in libavformat is also completely irrelevant for our use.

We should look for libavcodec instead.
Interestingly, libavformat doesn't appear to be installed on ubuntu unless you install the full ffmpeg or gstreamer-ffmpeg plugin.

So currently to use Firefox with ffmpeg, you must install gstreamer-ffmpeg which is rather a pity
Attachment #8667657 - Flags: review?(edwin)
Comment on attachment 8667657 [details] [diff] [review]
Remove dependency on libavformat.

Review of attachment 8667657 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp
@@ +30,5 @@
>  public:
>    static already_AddRefed<PlatformDecoderModule> Create();
>  };
>  
>  static const AvFormatLib sLibs[] = {

Rename |struct AvFormatLib|.
Attachment #8667657 - Flags: review?(edwin) → review+
Comment on attachment 8668286 [details] [diff] [review]
P2. Initialize PDM before attempting to use it.

Review of attachment 8668286 [details] [diff] [review]:
-----------------------------------------------------------------

(Jean-Yves requested I do the review, as we're not sure whether Edwin is available at the moment.)
Attachment #8668286 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/95fd37cd9c3e
https://hg.mozilla.org/mozilla-central/rev/9d7b74d45f71
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1214943
You need to log in before you can comment on or make changes to this bug.