1209806 - Remove dependency on libavformat

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

When searching for ffmpeg or libav we currently look for libavformat and search a specific version.

We have no use for the libavformat library as we only use libavcodec and indirectly libavutil.

The version numbering in libavformat is also completely irrelevant for our use.

We should look for libavcodec instead.

Comment 1

[Jean-Yves Avenard [:jya]]

Interestingly, libavformat doesn't appear to be installed on ubuntu unless you install the full ffmpeg or gstreamer-ffmpeg plugin.

So currently to use Firefox with ffmpeg, you must install gstreamer-ffmpeg which is rather a pity

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Remove dependency on libavformat.

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8667657 [details] [diff] [review]
Remove dependency on libavformat.

Review of attachment 8667657 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp
@@ +30,5 @@
>  public:
>    static already_AddRefed<PlatformDecoderModule> Create();
>  };
>  
>  static const AvFormatLib sLibs[] = {

Rename |struct AvFormatLib|.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: P2. Initialize PDM before attempting to use it.

Comment 5

[Gerald Squelart (he/him)]

Comment on attachment 8668286 [details] [diff] [review]
P2. Initialize PDM before attempting to use it.

Review of attachment 8668286 [details] [diff] [review]:
-----------------------------------------------------------------

(Jean-Yves requested I do the review, as we're not sure whether Edwin is available at the moment.)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95fd37cd9c3e
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d7b74d45f71

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95fd37cd9c3e
https://hg.mozilla.org/mozilla-central/rev/9d7b74d45f71

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e5871ff05771