Show the marks from |performance.mark| on Gecko profile

RESOLVED FIXED in Firefox 44

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: snowmantw, Assigned: ting)

Tracking

unspecified
mozilla44
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Currently we need to use |console.time| or other ways to show the specific marks on the profiling result, which is not intuitive enough as |performance.mark|. We should implement this.
(Assignee)

Comment 1

2 years ago
Created attachment 8667796 [details] [diff] [review]
patch v1
Attachment #8667796 - Flags: review?(amarchesini)
(Assignee)

Updated

2 years ago
Summary: [PerformanceTool] Add a new option to allow marks from |performance.mark| to show on the Gecko profiling result → Show the marks from |performance.mark| on Gecko profile
(Assignee)

Updated

2 years ago
Component: Performance → DOM
Product: Firefox OS → Core
Attachment #8667796 - Flags: review?(amarchesini) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → janus926
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 4

2 years ago
We have also Bug 1170314, console.timeStamp.

Comment 5

2 years ago
If this provides similar functionality, Bug 1170314 could be perhaps backed out, since performance.mark is perhaps a tiny bit less odd place to have this kind of side effects.
(Assignee)

Comment 6

2 years ago
Is it OK to ask sheriff to backout bug 1170314, or I should make a patch somewhere?
Flags: needinfo?(bugs)
https://hg.mozilla.org/mozilla-central/rev/2c3e1c2fc632
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

Comment 8

2 years ago
Could you still verify with BenWa that the functionality is the same, and if it is, then backing out that other patch/bug should be fine.
Flags: needinfo?(bugs)
(Assignee)

Comment 9

2 years ago
The cset on m-c and m-i are empty, seems something wrong with Pulsebot?
Status: RESOLVED → REOPENED
Flags: needinfo?(cbook)
Resolution: FIXED → ---
(Assignee)

Comment 10

2 years ago
(In reply to Olli Pettay [:smaug] from comment #8)
> Could you still verify with BenWa that the functionality is the same, and if
> it is, then backing out that other patch/bug should be fine.

It should be the same as both go to PROFILER_MARKER().

BenWa, could you confirm that bug 1170314 has the same functionality (add a marker to gecko profiler) with the patch here? Thank you.
Flags: needinfo?(bgirard)
landed again, seems qimport failed somehow before (no idea why)
Flags: needinfo?(cbook)
It looks like it is indeed duplicate. I'd say we should back bug 1170314 out.
Flags: needinfo?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/561ebe842566
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Depends on: 1213719
You need to log in before you can comment on or make changes to this bug.