1209871 - crash in java.lang.IllegalStateException: ScrollView can host only one direct child at android.widget.ScrollView.addView(ScrollView.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u549602]

This bug was filed from the Socorro interface and is 
report bp-c070f753-20f6-41d2-9664-4e8122150930.
=============================================================
Please note that this bug is a device specific issue

Steps to reproduce:
User taps on Awesomescreen and visits any tab 
User docks the device to the dock charger

Expected result:
Browser should not crash
Actual result:
Browser crashes

Please note that this issue occurs when docking/undocking device from charger and does not occur when the charger cable is directly connected to device

For further details please check: https://www.youtube.com/watch?v=M6LyEWpmsvk&feature=youtu.be


Crashing Thread
Frame	Module	Signature	Source
0	libxul.so	Java_org_mozilla_gecko_GeckoAppShell_reportJavaCrash	widget/android/AndroidJNI.cpp
Ø 1	data@[e-mail][e-mail]	data@[e-mail][e-mail]@0x8a1b6d	
Ø 2	dalvik-alloc space (deleted)	dalvik-alloc space (deleted)@0x21c4e	
Ø 3	dalvik-main space (deleted)	dalvik-main space (deleted)@0x1abfe	
Ø 4	dalvik-main space (deleted)	dalvik-main space (deleted)@0x70625e	
Ø 5	dalvik-main space (deleted)	dalvik-main space (deleted)@0x70625e	
Ø 6	dalvik-main space (deleted)	dalvik-main space (deleted)@0x70625e	
Ø 7	dalvik-alloc space (deleted)	dalvik-alloc space (deleted)@0x1f94e	
Ø 8	dalvik-main space (deleted)	dalvik-main space (deleted)@0x522d9e	
Ø 9	dalvik-non moving space (deleted)	dalvik-non moving space (deleted)@0x3b2586	
Ø 10	dalvik-main space (deleted)	dalvik-main space (deleted)@0x198fde	
Ø 11	dalvik-non moving space (deleted)	dalvik-non moving space (deleted)@0x3b2586	
Ø 12	data@[e-mail][e-mail]	data@[e-mail][e-mail]@0x8a0e73	
Ø 13	dalvik-alloc space (deleted)	dalvik-alloc space (deleted)@0x1f94e	
Ø 14	dalvik-main space (deleted)	dalvik-main space (deleted)@0x70625e

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Stack trace (truncated):
>	at android.widget.ScrollView.addView(ScrollView.java:266)
>	at org.mozilla.gecko.gfx.LayerView.onAttachedToWindow(LayerView.java:315)
>	at org.mozilla.gecko.GeckoView.onDetachedFromWindow(GeckoView.java:225)

Code snippet (GeckoView):
>    @Override
>    public void onDetachedFromWindow()
>    {
>        super.onAttachedToWindow();
>        window.disposeNative();
>    }

Is it really correct that we call super.onAttachedToWindow() from onDetachedFromWindow()?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> Stack trace (truncated):
> >	at android.widget.ScrollView.addView(ScrollView.java:266)
> >	at org.mozilla.gecko.gfx.LayerView.onAttachedToWindow(LayerView.java:315)
> >	at org.mozilla.gecko.GeckoView.onDetachedFromWindow(GeckoView.java:225)
> 
> Code snippet (GeckoView):
> >    @Override
> >    public void onDetachedFromWindow()
> >    {
> >        super.onAttachedToWindow();
> >        window.disposeNative();
> >    }
> 
> Is it really correct that we call super.onAttachedToWindow() from
> onDetachedFromWindow()?

Ugh, nope, should be super.onDetachedFromWindow.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Okay. I'll create a quick patch.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1209871-GeckoView.patch

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8667932 [details] [diff] [review]
1209871-GeckoView.patch

Review of attachment 8667932 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f620ddf0e688

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f620ddf0e688

Comment 8

[u549602]

Verified as fixed on latest Nightly build (44.0a1 / 2015-10-08) on Sony Xperia Z2