Closed
Bug 1209877
Opened 10 years ago
Closed 10 years ago
(Gaia RTL 2.5) Icon title: incorrect ellipsis position in RTL
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pelloux, Assigned: pelloux)
References
Details
Attachments
(1 file)
STR:
* configure your phone to use a RTL locale
* go to homescreeen and check application or bookmarks with long name (Markeplace or www.mozilla.org for instance)
Expected:
* "Marketpla...", "www.mozil..."
Actual:
* "...arketplace", "...ozilla.org"
|
||
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Assignee: nobody → pierre-eric
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8667756 [details] [review]
[gaia] Phoxygen:bug1209877-homescreen-fix-ellipsis-position-in-rtl > mozilla-b2g:master
Chris, can you have a look please?
Attachment #8667756 -
Flags: review?(chrislord.net)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8667756 [details] [review]
[gaia] Phoxygen:bug1209877-homescreen-fix-ellipsis-position-in-rtl > mozilla-b2g:master
This looks good, but this needs to be updated in the source repository: https://gitlab.com/Cwiiis/gaia-app-icon
Could you submit a pull request there, and update your pull request to use bower to update this file? ('bower update gaia-app-icon', run in apps/homescreen)
Flags: needinfo?(pierre-eric)
Attachment #8667756 -
Flags: review?(chrislord.net) → feedback+
PR submitted to source repository.
Flags: needinfo?(pierre-eric)
|
|
||
Comment 5•10 years ago
|
||
(In reply to pierre-eric from comment #4)
> PR submitted to source repository.
I've merged your PR, flag me when you've opened a PR for the Gaia update :)
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8667756 [details] [review]
[gaia] Phoxygen:bug1209877-homescreen-fix-ellipsis-position-in-rtl > mozilla-b2g:master
I've also opened a pull request to sync your changes to gaia-site-icon: https://github.com/gaia-components/gaia-site-icon/pull/9
Flags: needinfo?(chrislord.net)
Attachment #8667756 -
Flags: review+
|
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•10 years ago
|
||
Also merged into gaia-site-icon.
|
Assignee | |
Comment 10•10 years ago
|
||
SandKing: not sure why you tag this bug as "Depends on: 1213237" ?
|
|
||
Comment 11•10 years ago
|
||
This isn't dependent on bug 1213237 in any way.
No longer depends on: 1213237
You need to log in
before you can comment on or make changes to this bug.
Description
•