Closed Bug 1209885 Opened 10 years ago Closed 9 years ago

The UpdateManager unit-tests are misusing the navigator.mozMobileConnections mock

Categories

(Firefox OS Graveyard :: Gaia::System, enhancement)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
All
Gonk (Firefox OS)
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: gsvelto, Unassigned)

Details

+++ This bug was initially created as a clone of Bug #834462 +++ While working on bug 834462 I noticed that the unit-tests in apps/system/test/unit/update_manager_test.js are misusing the mozMobileConnections mock: the mTeardown() method is being invoked in the suiteTeardown() function instead of the teardown() function. This causes mocked connections to leak between different tests. Changing this causes five tests to fail which could highlight real problems (i.e. the tests were passing but they shouldn't have) or only issues with the tests themselves (the setup wasn't done properly because the leak was causing the test to work already).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.