1209887 - Remove usage of decoder monitor from WaveReader

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d2650805e16

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1209887. Part 1 - add assertions. r=jya.

Bug 1209887 - Remove usage of decoder monitor from WaveReader.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8668241 [details]
MozReview Request: Bug 1209887. Part 1 - add assertions. r=jya.

https://reviewboard.mozilla.org/r/20911/#review18815

The commit message is highly confusing as it does way more than removing the monitor : removing GetNextChunk which isn't used ; adding asserts etc.
maybe it would be better to split this patch between functional and tidying things up

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Sure. I will split the patch. Thanks for the review!

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8668241 [details]
MozReview Request: Bug 1209887. Part 1 - add assertions. r=jya.

Bug 1209887. Part 1 - add assertions. r=jya.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1209887. Part 2 - remove usage of decoder monitor. r=jya.

Bug 1209887. Part 2 - remove usage of decoder monitor. r=jya.

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1209887. Part 3 - remove unused code. r=jya.

Bug 1209887. Part 3 - remove unused code. r=jya.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4174ca0e2b32
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef11325051ad
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e575a81a5f5

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4174ca0e2b32
https://hg.mozilla.org/mozilla-central/rev/ef11325051ad
https://hg.mozilla.org/mozilla-central/rev/0e575a81a5f5