Closed Bug 1209914 Opened 6 years ago Closed 6 years ago

Use toJSON methods instead of explicit _serializeToJSON calls

Categories

(Firefox :: Search, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Attached patch PatchSplinter Review
- The aFilter parameter of SRCH_ENG__serializeToJSON(aFilter) is never 'used' (it's always true), and makes the code harder to read.
- The explicit _serializeToJSON calls make the code just more complicated, when naming the methods toJSON achieves the same behavior automatically.
Attachment #8667818 - Flags: review?(adw)
Attachment #8667818 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/7ac681cd9e4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.