Closed
Bug 1209919
Opened 10 years ago
Closed 10 years ago
Improving naming and comments in StructuredCloneHelper
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
79.28 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
sfink gave me extremely useful hints about naming and comments in StructuredCloneHelper.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8667837 -
Flags: review?(bugs)
Comment 2•10 years ago
|
||
+ // Like Write() but it support the transferring of objects.
supports
+ // The parent object is set internally just during the Read(). This method
+ // can be used by custom read functions to retrieve it.
That sounds like the parent object has something to do with CustomReadHandler.
Could you perhaps drop 'custom' from the comment
// Implementations of the virtual methods to allow cloning of DOM data
Is a bit vague "DOM data".
Perhaps something like
"Implementations of the virtual methods to allow cloning of objects which JS engine itself doesn't clone."
+ // These 2 static methods are useful to read/write fully serializable objects.
+ // They can be used by custom StructuredCloneHolderBase classes to
+ // serialize standard objects such as ImageData, CryptoKey, RTCCertificate,
+ // etc."
Why the word "standard" there.
+ ContextSupport mSupportedContexts;
I would probably call it mSupportedContext (without the 's'), but either way.
Updated•10 years ago
|
Attachment #8667837 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•