sfink gave me extremely useful hints about naming and comments in StructuredCloneHelper.
Created attachment 8667837 [details] [diff] [review] renaming.patch
Attachment #8667837 - Flags: review?(bugs)
+ // Like Write() but it support the transferring of objects. supports + // The parent object is set internally just during the Read(). This method + // can be used by custom read functions to retrieve it. That sounds like the parent object has something to do with CustomReadHandler. Could you perhaps drop 'custom' from the comment // Implementations of the virtual methods to allow cloning of DOM data Is a bit vague "DOM data". Perhaps something like "Implementations of the virtual methods to allow cloning of objects which JS engine itself doesn't clone." + // These 2 static methods are useful to read/write fully serializable objects. + // They can be used by custom StructuredCloneHolderBase classes to + // serialize standard objects such as ImageData, CryptoKey, RTCCertificate, + // etc." Why the word "standard" there. + ContextSupport mSupportedContexts; I would probably call it mSupportedContext (without the 's'), but either way.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.