Drop support for <MozParam condition="defaultEngine"

RESOLVED FIXED in Firefox 44

Status

()

P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Created attachment 8667838 [details] [diff] [review]
Patch

This feature was used (afaik) by the Google search plugin until bug 1103216.

When looking at the code of the _isDefaultEngine method, I noticed that it is definitely broken since we implemented region-defaults (bug 1175218), and nobody complained...

MXR tells me the only references to this in mozilla-central are in tests. The only references in l10n-central are the Google plugins for SeaMonkey in the Japanese locales (bug 1103970 has probably not been ported to SeaMonkey).

I double checked with mconnor if this was OK to remove or if we should fix it. He said this is currently not used but potentially valuable in the future. However, his final words were "Let's kill it for now, we can always add it back in the future if it's needed."
Attachment #8667838 - Flags: review?(adw)

Updated

3 years ago
Attachment #8667838 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/81ed15cfdbfa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.