Closed
Bug 1209922
Opened 10 years ago
Closed 10 years ago
Show read-only sheriffing menu even when not logged in
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
References
Details
Attachments
(1 file)
Bug 1117556 made it possible to see a read-only version of the sheriffing menu, even if a user doesn't have is_staff set (ie isn't a sheriff) - so long as you are logged in.
However I think it would be good to show this menu to everyone - even those not logged in.
This also reduces the test matrix for the menu bar, when smoke testing.
The conditional is located here:
https://github.com/mozilla/treeherder/blob/6a2ff517db2df579ad6fbd82444ca370ff3b3e3d/ui/partials/main/thGlobalTopNavPanel.html#L18
|
Assignee | |
Comment 1•10 years ago
|
||
Sure, yup that was the intended initial implementation (a staged experience) but I will switch it no problems.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Tweak PR for review :)
Attachment #8667924 -
Flags: review?(emorley)
|
Reporter | |
Updated•10 years ago
|
Attachment #8667924 -
Flags: review?(emorley) → review+
|
||
Comment 3•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/db1c5b9bbfec4e13a5be797e67ff822590eb64da
Bug 1209922 - Display sheriff menu for all users
|
|
Assignee | |
Comment 4•10 years ago
|
||
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•