1210005 - Search suggestions notification doesn't appear in urlbar if user has disabled history, bookmarks, open tabs suggestions

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect, P3)

Description

[arni2033]

STR:
0. Open Aurora (Nightly seem to don't display the notification at all)
1. Go to about:preferences#privacy, uncheck "Location bar" -> "History", "Bookmarks", "Open tabs"
2. Type "a b c" in location bar

Result:       Search suggestions notification isn't displayed
Expectations: Even the users who disabled any suggestions in location bar
              should be notified about new search suggestions feature

Marco, please close this if it's desired behavior or if it's not worth the effort

Comment 1

[Marco Bonardo [:mak]]

could you please attach a log from about:support?

Comment 2

[arni2033]

Attachment: Troubleshooting Information (Aurora, new EN profile) 2015.09.30 19-30-31.xht

Comment 3

[arni2033]

Attachment: Troubleshooting Information (DevEdition, EN, new profile with only 3 checkboxes unchecked) 2015.09.30 21-46-49.xht

I'm sorry, I've mistaken 1st time. Here's the correct file. All 3 prefs - "browser.urlbar.suggest.bookmark", "browser.urlbar.suggest.history", "browser.urlbar.suggest.openpage" are displayed as "false" there.
Are you asking because you can't reproduce this?

Comment 4

[Marco Bonardo [:mak]]

I suspect the problem is that browser.urlbar.suggest.searches is false by default. when you also disable the other browser.urlbar.suggest.* prefs we set browser.urlbar.autocomplete.enabled to false. indeed your about:support log reports autocomplete.enabled == false.

Could you please confirm that the checkbox "Show search suggestions in location bar results" in Preferences / Search is unchecked?
Since autocomplete is disabled, we don't show the notification. Enabling one of the Privacy options should show it... enabling suggestions in Search will just enable the feature.

It's an edge case that basically happens if all autocomplete options are disabled, and the user can still enable each option properly in the Preferences panel. I'm not sure if it's worth spending time on this, or better to remove autocomplete.enabled completely.
I'd probably vote for the latter, once we release unified complete, we can remove autocomplete.enabled support from it and Firefox and leave it just in the legacy autocomplete component that Firefox won't use anymore.

Comment 5

[arni2033]

Oh, I just managed to reproduce it on Nightly too. Yes, I only disabled those 3 checkboxes http://ssmaker.ru/14590b70.png and left this one untouched http://ssmaker.ru/4715f2ea.png

Comment 6

[Marco Bonardo [:mak]]

The notification has been removed