1210077 - HttpChannelChild::ResetInterception needs to check to see if gNeckoChild is null before calling ContinueAsyncOpen

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Otherwise we crash.  I saw this when shutting down a browser that was in the middle of doing service workery things, and AsyncOpen already null checks gNeckoChild.

Comment 1

[(no longer active)]

Attachment: Null check gNeckoChild in HttpChannelChild::ResetInterception()

Comment 2

[(no longer active)]

Comment on attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()

Approval Request Comment
[Feature/regressing bug #]: ServiceWorkers
[User impact if declined]: This fixes a crash which we don't have an STR for.
[Describe test coverage new/current, TreeHerder]: Untested, but obviously gets the job done.  :-)
[Risks and why]: Doesn't add any risks to non-SW things.
[String/UUID change made/needed]: None.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac45ff7a16bc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac45ff7a16bc

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()

Approved for aurora uplift, fixes a crash in feature aimed at 43

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4000e937a649