Closed Bug 1210077 Opened 6 years ago Closed 6 years ago
Channel Child::Reset Interception needs to check to see if g Necko Child is null before calling Continue Async Open
Otherwise we crash. I saw this when shutting down a browser that was in the middle of doing service workery things, and AsyncOpen already null checks gNeckoChild.
Attachment #8671051 - Flags: review?(mcmanus) → review+
Comment on attachment 8671051 [details] [diff] [review] Null check gNeckoChild in HttpChannelChild::ResetInterception() Approval Request Comment [Feature/regressing bug #]: ServiceWorkers [User impact if declined]: This fixes a crash which we don't have an STR for. [Describe test coverage new/current, TreeHerder]: Untested, but obviously gets the job done. :-) [Risks and why]: Doesn't add any risks to non-SW things. [String/UUID change made/needed]: None.
Attachment #8671051 - Flags: approval-mozilla-aurora?
Comment on attachment 8671051 [details] [diff] [review] Null check gNeckoChild in HttpChannelChild::ResetInterception() Approved for aurora uplift, fixes a crash in feature aimed at 43
Attachment #8671051 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.