All users were logged out of Bugzilla on October 13th, 2018

HttpChannelChild::ResetInterception needs to check to see if gNeckoChild is null before calling ContinueAsyncOpen

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: khuey, Assigned: Ehsan)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

Attachments

(1 attachment)

Otherwise we crash.  I saw this when shutting down a browser that was in the middle of doing service workery things, and AsyncOpen already null checks gNeckoChild.
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()
Attachment #8671051 - Flags: review?(mcmanus)
Attachment #8671051 - Flags: review?(mcmanus) → review+
(Assignee)

Comment 2

3 years ago
Comment on attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()

Approval Request Comment
[Feature/regressing bug #]: ServiceWorkers
[User impact if declined]: This fixes a crash which we don't have an STR for.
[Describe test coverage new/current, TreeHerder]: Untested, but obviously gets the job done.  :-)
[Risks and why]: Doesn't add any risks to non-SW things.
[String/UUID change made/needed]: None.
Attachment #8671051 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ac45ff7a16bc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()

Approved for aurora uplift, fixes a crash in feature aimed at 43
Attachment #8671051 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.