Emit object:state-changed:showing event for doorhangers

RESOLVED FIXED in Firefox 44

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: Joanmarie Diggs, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla44
Unspecified
Linux
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

930 bytes, patch
tbsaunde
: review+
Details | Diff | Splinter Review
(Reporter)

Description

2 years ago
When a doorhanger is shown to the user in Windows, as I understand it, an alert event is emitted along with whatever event is emitted to indicate the accessible tree has been modified.

Unfortunately, ATK/AT-SPI2 doesn't have an alert event. We could add one. But that would not help users now, nor would it help users who do not update to the latest version of their distro in the future. I think a reasonable alternative would be to emit object:state-changed:showing when a doorhanger's showing state changes. This is the event emitted by other applications and toolkits implementing ATK when tooltips, notifications, and the like are shown.
(Assignee)

Comment 1

2 years ago
Created attachment 8668079 [details] [diff] [review]
patch
Attachment #8668079 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Comment 2

2 years ago
Created attachment 8668083 [details] [diff] [review]
patch2
Attachment #8668079 - Attachment is obsolete: true
Attachment #8668079 - Flags: review?(tbsaunde+mozbugs)
Attachment #8668083 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8668083 [details] [diff] [review]
patch2

>+      // ATK doesn't have a better match, Orca knows how to handle that.

that comment doesn't seem great.  Why don't you explicitly says it hack using state change showing events as alert events? or something like that?

>+      atk_object_notify_state_change(&atkObj, ATK_STATE_SHOWING, true);

stray &
Attachment #8668083 - Flags: review?(tbsaunde+mozbugs) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/95fb2b552c0d
https://hg.mozilla.org/mozilla-central/rev/95fb2b552c0d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Reporter)

Updated

2 years ago
Blocks: 1272685
(Reporter)

Updated

2 years ago
No longer blocks: 1272685
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.