1210108 - Emit object:state-changed:showing event for doorhangers

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Joanmarie Diggs]

When a doorhanger is shown to the user in Windows, as I understand it, an alert event is emitted along with whatever event is emitted to indicate the accessible tree has been modified.

Unfortunately, ATK/AT-SPI2 doesn't have an alert event. We could add one. But that would not help users now, nor would it help users who do not update to the latest version of their distro in the future. I think a reasonable alternative would be to emit object:state-changed:showing when a doorhanger's showing state changes. This is the event emitted by other applications and toolkits implementing ATK when tooltips, notifications, and the like are shown.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8668083 [details] [diff] [review]
patch2

>+      // ATK doesn't have a better match, Orca knows how to handle that.

that comment doesn't seem great.  Why don't you explicitly says it hack using state change showing events as alert events? or something like that?

>+      atk_object_notify_state_change(&atkObj, ATK_STATE_SHOWING, true);

stray &

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95fb2b552c0d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95fb2b552c0d