1210133 - Intermittent test_filehandle_getFile.html | indexedDB error, 'AbortError'

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Reporter

Description

•

9 years ago

https://treeherder.mozilla.org/logviewer.html#?job_id=2904202&repo=b2g-inbound

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=2904202
repository: b2g-inbound
start_time: 2015-09-30T06:37:01
who: wkocher[at]mozilla[dot]com
machine: t-snow-r4-0155
buildname: Rev4 MacOSX Snow Leopard 10.6 b2g-inbound opt test mochitest-2
revision: 0d049c0cdf54

2200 INFO TEST-UNEXPECTED-FAIL | dom/indexedDB/test/test_filehandle_getFile.html | indexedDB error, 'AbortError'
2202 INFO TEST-UNEXPECTED-ERROR | dom/indexedDB/test/test_filehandle_getFile.html | called finish() multiple times

Comment hidden (Intermittent Failures Robot)

8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* b2g-inbound: 2
* try: 1
* mozilla-beta: 1
* mozilla-aurora: 1

Platform breakdown:
* osx-10-6: 4
* linux64: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2015-10-26&endday=2015-11-01&tree=all

Comment hidden (Intermittent Failures Robot)

11 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* mozilla-central: 3
* fx-team: 2
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* osx-10-6: 6
* linux64: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2015-11-02&endday=2015-11-08&tree=all

Comment hidden (Intermittent Failures Robot)

9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* fx-team: 2
* b2g-inbound: 2
* mozilla-central: 1

Platform breakdown:
* linux32: 5
* osx-10-6: 3
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2015-11-09&endday=2015-11-15&tree=all

Comment hidden (Intermittent Failures Robot)

8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-aurora: 2
* mozilla-central: 1
* mozilla-beta: 1
* fx-team: 1

Platform breakdown:
* osx-10-6: 5
* linux32: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2015-11-16&endday=2015-11-22&tree=all

Comment hidden (Intermittent Failures Robot)

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* mozilla-aurora: 1
* fx-team: 1

Platform breakdown:
* osx-10-6: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2016-02-29&endday=2016-03-06&tree=all

BMO Automation

Comment 7

•

8 years ago

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Priority: -- → P3

Comment hidden (Intermittent Failures Robot)

2 failures in 814 pushes (0.002 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-esr45: 1
* autoland: 1

Platform breakdown:
* windows7-32-vm: 1
* osx-10-6: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2017-06-12&endday=2017-06-18&tree=all

Geoff Brown [:gbrown]

Updated

•

7 years ago

Priority: P3 → P5

Comment hidden (Intermittent Failures Robot)

1 failures in 849 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2017-11-06&endday=2017-11-12&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 735 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2018-01-29&endday=2018-02-04&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 685 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1210133&startday=2018-02-12&endday=2018-02-18&tree=all

Comment hidden (Intermittent Failures Robot)

3 failures in 521 pushes (0.006 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 2
* mozilla-inbound: 1

Platform breakdown:
* linux64-devedition: 2
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1210133&startday=2018-06-18&endday=2018-06-24&tree=trunk

Comment hidden (Intermittent Failures Robot)

1 failures in 2740 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1210133&startday=2018-10-08&endday=2018-10-14&tree=all

Comment hidden (Intermittent Failures Robot)

2 failures in 2759 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1
* try: 1

Platform breakdown:
* windows10-64: 1
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1210133&startday=2018-10-15&endday=2018-10-21&tree=all

Comment hidden (Intermittent Failures Robot)

3 failures in 2808 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 1
* linux64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1210133&startday=2018-11-26&endday=2018-12-02&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 2648 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1210133&startday=2018-12-17&endday=2018-12-23&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 1008 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1210133&startday=2018-12-24&endday=2018-12-30&tree=all

Comment hidden (Intermittent Failures Robot)

Geoff Brown [:gbrown]

Comment 23

•

5 years ago

Recent failure:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235709330&repo=autoland&lineNumber=7195

[task 2019-03-24T08:26:58.244Z] 08:26:58     INFO - TEST-INFO | started process screentopng
[task 2019-03-24T08:26:59.280Z] 08:26:59     INFO - TEST-INFO | screentopng: exit 0
[task 2019-03-24T08:26:59.282Z] 08:26:59     INFO - Buffered messages logged at 08:26:58
[task 2019-03-24T08:26:59.283Z] 08:26:59     INFO - Running
[task 2019-03-24T08:26:59.284Z] 08:26:59     INFO - Pushing preferences
[task 2019-03-24T08:26:59.285Z] 08:26:59     INFO - Pushing permissions
[task 2019-03-24T08:26:59.286Z] 08:26:59     INFO - Clearing old databases
[task 2019-03-24T08:26:59.287Z] 08:26:59     INFO - TEST-FAIL | dom/indexedDB/test/test_filehandle_getFile.html | Skipping test in a worker because it's not structured properly 
[task 2019-03-24T08:26:59.289Z] 08:26:59     INFO - Running test in main thread
[task 2019-03-24T08:26:59.291Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Correct interface 
[task 2019-03-24T08:26:59.293Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Correct interface 
[task 2019-03-24T08:26:59.294Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist 
[task 2019-03-24T08:26:59.297Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist 
[task 2019-03-24T08:26:59.298Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist 
[task 2019-03-24T08:26:59.300Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist 
[task 2019-03-24T08:26:59.301Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist 
[task 2019-03-24T08:26:59.302Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist 
[task 2019-03-24T08:26:59.304Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Async/await tests shouldn't call finishTest() 
[task 2019-03-24T08:26:59.305Z] 08:26:59     INFO - Buffered messages finished
[task 2019-03-24T08:26:59.306Z] 08:26:59     INFO - TEST-UNEXPECTED-FAIL | dom/indexedDB/test/test_filehandle_getFile.html | indexedDB error, 'AbortError' 
[task 2019-03-24T08:26:59.308Z] 08:26:59     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-24T08:26:59.309Z] 08:26:59     INFO -     errorHandler@dom/indexedDB/test/helpers.js:206:3
[task 2019-03-24T08:26:59.310Z] 08:26:59     INFO -     EventHandlerNonNull*testSteps@dom/indexedDB/test/test_filehandle_getFile.html:31:5
[task 2019-03-24T08:26:59.311Z] 08:26:59     INFO -     grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:189:17
[task 2019-03-24T08:26:59.313Z] 08:26:59     INFO -     EventHandlerNonNull*testSteps@dom/indexedDB/test/test_filehandle_getFile.html:27:5
[task 2019-03-24T08:26:59.314Z] 08:26:59     INFO -     grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:189:17
[task 2019-03-24T08:26:59.315Z] 08:26:59     INFO -     EventHandlerNonNull*testSteps@dom/indexedDB/test/test_filehandle_getFile.html:19:5
[task 2019-03-24T08:26:59.316Z] 08:26:59     INFO -     testHarnessSteps@dom/indexedDB/test/helpers.js:155:19
[task 2019-03-24T08:26:59.318Z] 08:26:59     INFO -     nextTestHarnessStep@dom/indexedDB/test/helpers.js:49:26
[task 2019-03-24T08:26:59.319Z] 08:26:59     INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Async/await tests shouldn't call finishTest() 
[task 2019-03-24T08:26:59.320Z] 08:26:59     INFO - GECKO(3969) | MEMORY STAT | vsize 1484MB | residentFast 125MB | heapAllocated 14MB
[task 2019-03-24T08:26:59.323Z] 08:26:59    ERROR - [SimpleTest.finish()] this test already called finish!
[task 2019-03-24T08:26:59.325Z] 08:26:59     INFO - TEST-UNEXPECTED-ERROR | dom/indexedDB/test/test_filehandle_getFile.html | called finish() multiple times

:ttung -- I wonder if this might have been caused or triggered by bug 1498183? Can you have a look?

Flags: needinfo?(shes050117)

Tom Tung [:tt, :ttung]

Comment 24

•

5 years ago

(In reply to Geoff Brown [:gbrown] from comment #23)

:ttung -- I wonder if this might have been caused or triggered by bug 1498183? Can you have a look?

It doesn't look like because the change in bug 1498183 is for supporting async/await on indexedDB tests. And, the error here are "indexedDB error, 'AbortError'", and "called finish() multiple times".

The second error is probably because there is a race between onerror event (it will call finish() in errorHandler [1]) and at the end of the test itself (calling finish).

Thus, if we can fix the first one than all the stuff should be fixed. (The 'AbortError' shouldn't be caused by bug 1498183)

[1] https://searchfox.org/mozilla-central/rev/ddd1679c0534f7ddf36cafddd17b710c4fefe3c4/dom/indexedDB/test/helpers.js#207

Flags: needinfo?(shes050117)

Comment hidden (Intermittent Failures Robot)

Andreea Pavel [:apavel]

Comment 26

•

5 years ago

There are 22 total failures in the last 7 days on android-em-7-0-x86_64 opt, linux32 debug, linux32-shippable opt, linux64-qr and linux64-shippable-qr opt

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238581967&repo=mozilla-inbound&lineNumber=7364

[task 2019-04-06T13:13:33.204Z] 13:13:33 [task 2019-04-06T13:13:33.329Z] 13:13:33 [task 2019-04-06T13:13:34.451Z] 13:13:34 [task 2019-04-06T13:13:34.452Z] 13:13:34 [task 2019-04-06T13:13:34.452Z] 13:13:34 [task 2019-04-06T13:13:34.452Z] 13:13:34 [task 2019-04-06T13:13:34.452Z] 13:13:34 [task 2019-04-06T13:13:34.453Z] 13:13:34 [task 2019-04-06T13:13:34.453Z] 13:13:34 [task 2019-04-06T13:13:34.453Z] 13:13:34 [task 2019-04-06T13:13:34.453Z] 13:13:34 [task 2019-04-06T13:13:34.453Z] 13:13:34 [task 2019-04-06T13:13:34.456Z] 13:13:34 [task 2019-04-06T13:13:34.457Z] 13:13:34 [task 2019-04-06T13:13:34.459Z] 13:13:34 [task 2019-04-06T13:13:34.460Z] 13:13:34 [task 2019-04-06T13:13:34.462Z] 13:13:34 [task 2019-04-06T13:13:34.464Z] 13:13:34 [task 2019-04-06T13:13:34.466Z] 13:13:34 [task 2019-04-06T13:13:34.468Z] 13:13:34 [task 2019-04-06T13:13:34.470Z] 13:13:34 [task 2019-04-06T13:13:34.472Z] 13:13:34 [task 2019-04-06T13:13:34.473Z] 13:13:34 [task 2019-04-06T13:13:34.475Z] 13:13:34 [task 2019-04-06T13:13:34.476Z] 13:13:34 [task 2019-04-06T13:13:34.478Z] 13:13:34 [task 2019-04-06T13:13:34.479Z] 13:13:34 [task 2019-04-06T13:13:34.482Z] 13:13:34 [task 2019-04-06T13:13:34.484Z] 13:13:34 [task 2019-04-06T13:13:34.486Z] 13:13:34 [task 2019-04-06T13:13:34.487Z] 13:13:34 [task 2019-04-06T13:13:34.489Z] 13:13:34 [task 2019-04-06T13:13:34.490Z] 13:13:34 [task 2019-04-06T13:13:34.492Z] 13:13:34 [task 2019-04-06T13:13:34.494Z] 13:13:34 [task 2019-04-06T13:13:34.499Z] 13:13:34 INFO - TEST-START | dom/indexedDB/test/test_filehandle_getFile.html
INFO - TEST-INFO | started process screentopng
INFO - TEST-INFO | screentopng: exit 0
INFO - Buffered messages logged at 13:13:33
INFO - Running
INFO - Pushing preferences
INFO - Pushing permissions
INFO - Clearing old databases
INFO - TEST-FAIL | dom/indexedDB/test/test_filehandle_getFile.html | Skipping test in a worker because it's not structured properly
INFO - Running test in main thread
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Correct interface
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Correct interface
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Property should not exist
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Async/await tests shouldn't call finishTest()
INFO - Buffered messages finished
INFO - TEST-UNEXPECTED-FAIL | dom/indexedDB/test/test_filehandle_getFile.html | indexedDB error, 'AbortError'
INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
INFO - errorHandler@dom/indexedDB/test/helpers.js:206:3
INFO - EventHandlerNonNulltestSteps@dom/indexedDB/test/test_filehandle_getFile.html:31:5
INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:189:17
INFO - EventHandlerNonNulltestSteps@dom/indexedDB/test/test_filehandle_getFile.html:27:5
INFO - grabEventAndContinueHandler@dom/indexedDB/test/helpers.js:189:17
INFO - EventHandlerNonNull*testSteps@dom/indexedDB/test/test_filehandle_getFile.html:19:5
INFO - testHarnessSteps@dom/indexedDB/test/helpers.js:155:19
INFO - nextTestHarnessStep@dom/indexedDB/test/helpers.js:49:26
INFO - TEST-PASS | dom/indexedDB/test/test_filehandle_getFile.html | Async/await tests shouldn't call finishTest()
INFO - GECKO(3972) | MEMORY STAT | vsize 1485MB | residentFast 125MB | heapAllocated 14MB
ERROR - [SimpleTest.finish()] this test already called finish!
INFO - TEST-UNEXPECTED-ERROR | dom/indexedDB/test/test_filehandle_getFile.html | called finish() multiple times
INFO - TEST-INFO took 138ms
INFO - TEST-OK | dom/indexedDB/test/test_filehandle_getFile.html

Geoff is this something you are looking into?

Flags: needinfo?(gbrown)

Whiteboard: [stockwell needswork:owner]

Comment hidden (Intermittent Failures Robot)

Geoff Brown [:gbrown]

Comment 28

•

5 years ago

(In reply to Andreea Pavel [:apavel] from comment #26)

Geoff is this something you are looking into?

No, not at all.

Flags: needinfo?(gbrown)

Andreea Pavel [:apavel]

Comment 29

•

5 years ago

Andrew can you assign someone here?

Flags: needinfo?(overholt)

Andrew Overholt [:overholt]

Comment 30

•

5 years ago

I can't assign someone right now but we will soon have time on the team to take this on. Thanks for bringing it to my attention, Andreea!

Flags: needinfo?(overholt)

Priority: P5 → P2

Andreea Pavel [:apavel]

Comment 31

•

5 years ago

Thanks Andrew!

Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][comment 30]

Comment hidden (Intermittent Failures Robot)

Razvan Maries

Comment 52

•

5 years ago

There are 75 total failures in the last 7 days: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-08-04&endday=2019-08-11&tree=trunk&bug=1210133

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261015028&repo=mozilla-central&lineNumber=3882

Any updates here Andrew?

Flags: needinfo?(overholt)

Comment hidden (Intermittent Failures Robot)

Andrew Overholt [:overholt]

Comment 55

•

5 years ago

I'll redirect this to Hsin-Yi who manages the team now.

Flags: needinfo?(overholt) → needinfo?(htsai)

Comment hidden (Intermittent Failures Robot)

Hsin-Yi Tsai (she/her) [:hsinyi]

Comment 57

•

5 years ago

Just talking with team, we can disable the test given we're going to remove FileHandle support from IDB.

Flags: needinfo?(htsai)

Comment hidden (Intermittent Failures Robot)

Daniel Varga [:dvarga]

Comment 60

•

5 years ago

Attached file Bug 1210133 - test_filehandle_getFile.html on all platforms - FileHandle will be removed from IDB. r=jmaher — Details

Comment hidden (Intermittent Failures Robot)

Pulsebot

Comment 62

•

5 years ago

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53cb6344eb97
test_filehandle_getFile.html on all platforms - FileHandle will be removed from IDB. r=jmaher

Razvan Maries

Updated

•

5 years ago

Keywords: leave-open

Whiteboard: [comment 30][stockwell disable-recommended] → [comment 30][stockwell disabled]

Andrei Ciure[:aciure]

Comment 63

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/53cb6344eb97

Comment hidden (Intermittent Failures Robot)

Simon Giesecke [:sg] [he/him]

Comment 82

•

4 years ago

IIRC, getFile was removed from trunk. The test is still active on esr68, should it be disabled there at least?

Flags: needinfo?(jvarga)

Jan Varga [:janv]

Comment 83

•

4 years ago

Yeah, we can disable it (we don't expect uplifting changes that would break it there).

Flags: needinfo?(jvarga)

Simon Giesecke [:sg] [he/him]

Comment 84

•

4 years ago

[Tracking Requested - why for this release]: Intermittent test failures. The test was previously disabled and ultimately removed with the implementation of getFile from trunk. We don't plan to uplift any production code changes relating to this to esr68.

status-firefox-esr68: --- → checkin-pending

tracking-firefox-esr68: --- → ?

Ryan VanderMeulen [:RyanVM]

Comment 85

•

4 years ago

We don't need to track this for ESR68, but sure, we can uplift the test disabling there. Sounds like this bug is a wontfix at this point too.

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox-esr68: checkin-pending → affected

tracking-firefox-esr68: ? → ---

Resolution: --- → WONTFIX

Whiteboard: [comment 30][stockwell disabled] → [comment 30][stockwell disabled][checkin-needed-esr68]

BugBot [:suhaib / :marco/ :calixte]

Updated

•

4 years ago

Keywords: leave-open

Andreea Pavel [:apavel]

Comment 86

•

4 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-esr68/rev/dfb92d98c6fa

status-firefox-esr68: affected → fixed

Whiteboard: [comment 30][stockwell disabled][checkin-needed-esr68] → [comment 30][stockwell disabled]

Andreea Pavel [:apavel]

Updated

•

4 years ago

status-firefox-esr68: fixed → disabled