1210196 - Support minUnit, maxUnit and negative values in mozIntl.DurationFormat

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

DurationFormat should handle negative values.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1210196-support-negative-values-in-durationformat > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8668158 [details] [review]
[gaia] zbraniecki:1210196-support-negative-values-in-durationformat > mozilla-b2g:master

I thought I can wait with enabling more duration patterns, but Music could use "mm:ss" right now, so I expanded it.

I also added naive ability to put negative sign. I thought about adding negative sign to the pattern in l10n file, but so far it seems that no locale needs it (scanning through CLDR) and I decided it would just confuse localizers.

I expect that if I'm wrong, we'll update it once we get an algorithm in the spec (which may end up being part of UnitFormat anyway).

For now, this should handle all use cases that we need it for and I don't plan on adding UnitFormat to mozIntl in 2.5 because it seems like a major task and lots of new strings for localizers.

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 8668158 [details] [review]
[gaia] zbraniecki:1210196-support-negative-values-in-durationformat > mozilla-b2g:master

lgtm, r=me, thanks!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/bda68b65184e09957a2170ca01c25bdb9b0cfc41

Comment 5

[Johan Lorenzo [:jlorenzo]]

Backed out for preventing to revert bug 1207044, which was causing bug 1210234. The merge[1] and the follow up[2] were backed out.

[1] https://github.com/mozilla-b2g/gaia/commit/0333858eeccf285be53826ef43c3a9c8ca3714ec
[2] https://github.com/mozilla-b2g/gaia/commit/1aacacc9df5ff349b4653b235e96d7141faabbe0

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Relanded in bug 1207044