1210265 - Add a pref toggle for copying/pasting non-text/rich text in B2G clipboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Boris Chiou [:boris]]

Bug 952456 add a new feature to support non-text/rich text for B2G clipboard, but some apps (ex. SMS app) only handle plain-text. According to Bug 952456 Comment 79, we could put the functionality behind a pref for 2.5 to make sure it wouldn't break those apps on 2.5.

Comment 1

[Boris Chiou [:boris]]

Attachment: Add pref toggle for copying/pasting only plain text on B2G

Add a new preference, clibboard.plainTextOnly.
1. On:  we only support kUnicodeMIME in SetData/GetData.
2. Off: we can support different MIME types in SetData/GetData

BTW, "copy image" is dependent on non-text/rich text support, so this
menu item is also disabled after we turn it off.

Comment 2

[Boris Chiou [:boris]]

Attachment: Add pref toggle for copying/pasting only plain text on B2G (v2)

Add a new preference, clibboard.plainTextOnly.
1. On:  we only support kUnicodeMIME in SetData/GetData.
2. Off: we can support different MIME types in SetData/GetData

BTW, "copy image" is dependent on non-text/rich text support, so this
menu item is also disabled after we turn it off.

Comment 3

[Boris Chiou [:boris]]

Attachment: Add pref toggle for copying/pasting only plain text on B2G (v3)

Add a new preference, clibboard.plainTextOnly.
1. On:  we only support kUnicodeMIME in SetData/GetData.
2. Off: we can support different MIME types in SetData/GetData

BTW, "copy image" is dependent on non-text/rich text support, so this
menu item is also disabled after we turn it off.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] BorisChiou:Bug1210265 > mozilla-b2g:master

Comment 5

[Boris Chiou [:boris]]

Attachment: Add pref toggle for copying/pasting only plain text on B2G (v4)

Add a new preference, clibboard.plainTextOnly.
1. On:  we only support kUnicodeMIME in SetData/GetData.
2. Off: we can support different MIME types in SetData/GetData

BTW, "copy image" is dependent on non-text/rich text support, so this
menu item is also disabled after we turn it off.

Comment 6

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1537f2f58b1c

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8668325 [details] [diff] [review]
Add pref toggle for copying/pasting only plain text on B2G (v4)

Review of attachment 8668325 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: b2g/app/b2g.js
@@ +1150,5 @@
>  pref("b2g.multiscreen.chrome_remote_url", "chrome://b2g/content/shell_remote.html");
>  pref("b2g.multiscreen.system_remote_url", "index_remote.html");
>  
> +// Clipboard only supports text/plain
> +pref("clipboard.plainTextOnly", true);

We can keep that to false on m-c. We'll switch to true once we branch if needed.

::: widget/gonk/nsClipboard.cpp
@@ +51,5 @@
>  
>    // Clear out the clipboard in order to set the new data
>    EmptyClipboard(aWhichClipboard);
>  
> +  // Bug 1210265: Use a pref to toggle rich text/non-text support

Nit: no need to put the bug number in the comment, but add a full stop at the end.

@@ +181,5 @@
>      nsRefPtr<nsClipboardProxy> clipboardProxy = new nsClipboardProxy();
>      return clipboardProxy->GetData(aTransferable, aWhichClipboard);
>    }
>  
> +  // Bug 1210265: Use a pref to toggle rich text/non-text support

nit: same as the other comment.

Comment 8

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82e9e427e6e4

Comment 9

[Boris Chiou [:boris]]

Comment on attachment 8668325 [details] [diff] [review]
Add pref toggle for copying/pasting only plain text on B2G (v4)

Review of attachment 8668325 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +1150,5 @@
>  pref("b2g.multiscreen.chrome_remote_url", "chrome://b2g/content/shell_remote.html");
>  pref("b2g.multiscreen.system_remote_url", "index_remote.html");
>  
> +// Clipboard only supports text/plain
> +pref("clipboard.plainTextOnly", true);

OK.

Comment 10

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a77b51666f0e

Comment 11

[Boris Chiou [:boris]]

Attachment: Add a pref toggle for copying/pasting only plain text on B2G (v5, carry fabrice's r+)

Add a new preference, clibboard.plainTextOnly.
1. On:  we only support kUnicodeMIME in SetData/GetData.
2. Off: we can support different MIME types in SetData/GetData

BTW, "copy image" is dependent on non-text/rich text support, so this
menu item is also disabled after we turn the pref off.

Fix some mochitest errors.

Comment 12

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e596b24feedb

Comment 13

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a09ac209822

Comment 14

[Boris Chiou [:boris]]

Hi Sheriff,

Could you please check in gaia and gecko parts together? Thanks.

Comment 15

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/e217e18b96aff349332373a3e6eedb6b8067a19a

also gecko part landed :)

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f58a232fc058

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f58a232fc058