use parameter index instead of node callback for sending timeline events

RESOLVED FIXED in Firefox 44

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla44
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(4 attachments)

Assignee

Description

4 years ago
We can remove one level of boilerplate for parameter updates.
Assignee

Comment 1

4 years ago
bug 1210266 use parameter index instead of node callback for sending timeline events r?padenot
Attachment #8668249 - Flags: review?(padenot)
Assignee

Comment 2

4 years ago
bug 1210266 remove unused AudioParam::Node() r?padenot
Attachment #8668250 - Flags: review?(padenot)
Assignee

Comment 3

4 years ago
bug 1210266 remove unused AudioNode::Callback() r?padenot
Attachment #8668251 - Flags: review?(padenot)
Assignee

Comment 4

4 years ago
bug 1210266 unfriend AudioBufferSourceNode from AudioNode r?padenot
Attachment #8668252 - Flags: review?(padenot)
Comment on attachment 8668249 [details]
MozReview Request: bug 1210266 use parameter index instead of node callback for sending timeline events r?padenot

https://reviewboard.mozilla.org/r/20927/#review18819

I always wondered why it was originally done with those callbacks instead of an index, and I was about to do this, heh.
Attachment #8668249 - Flags: review?(padenot) → review+
Comment on attachment 8668250 [details]
MozReview Request: bug 1210266 remove unused AudioParam::Node() r?padenot

https://reviewboard.mozilla.org/r/20929/#review18821
Attachment #8668250 - Flags: review?(padenot) → review+
Comment on attachment 8668251 [details]
MozReview Request: bug 1210266 remove unused AudioNode::Callback() r?padenot

https://reviewboard.mozilla.org/r/20931/#review18823
Attachment #8668251 - Flags: review?(padenot) → review+
Comment on attachment 8668252 [details]
MozReview Request: bug 1210266 unfriend AudioBufferSourceNode from AudioNode r?padenot

https://reviewboard.mozilla.org/r/20933/#review18825
Attachment #8668252 - Flags: review?(padenot) → review+
Assignee

Updated

4 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.