1210283 - Add more UI Telemetry probes for managing Home Panels

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We only had a single probe, setdefault.1, which tracking setting a default home panel. We should add probes for hide, show and remove. I suppose we could add a probe for a general move, but I don't know that up or down is needed.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: homepanel-settings-probes v0.1

This patch adds probes for HIDE, SHOW, MOVE and REMOVE Events. It also changes the text name of "setdefault.1" to "panel.setdefault.1" to match the convention used for "search.*.1" Events. Also uses DIALOG for the Method, like "search.*.1" does.

I will update the analysis script to handle old "setdefault.1" -> "panel.setdefault.1" renames. I already do that for a few others.

Tested and I see the right output in the logcat.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: uitelemetry-docs v0.1

This patch updates the docs to list the new Events.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8668259 [details] [diff] [review]
homepanel-settings-probes v0.1

Review of attachment 8668259 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I wonder if people change their panel orders...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dcbe3158d29d
https://hg.mozilla.org/integration/fx-team/rev/bce73b114fdc

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dcbe3158d29d
https://hg.mozilla.org/mozilla-central/rev/bce73b114fdc

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8668259 [details] [diff] [review]
homepanel-settings-probes v0.1

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: We'd like to get more telemetry info
[Describe test coverage new/current, TreeHerder]: Landed on Nightly and probes are reporting well.
[Risks and why]: Low
[String/UUID change made/needed]: None

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8668259 [details] [diff] [review]
homepanel-settings-probes v0.1

Sure, should be in 42 beta 6.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b8cdb043ac3e
https://hg.mozilla.org/releases/mozilla-aurora/rev/62ffae819bfb

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/097b17458da1