Closed
Bug 1210283
Opened 6 years ago
Closed 6 years ago
Add more UI Telemetry probes for managing Home Panels
Categories
(Firefox for Android Graveyard :: Settings and Preferences, defect)
Firefox for Android Graveyard
Settings and Preferences
Tracking
(firefox42 fixed, firefox43 fixed, firefox44 fixed)
RESOLVED
FIXED
Firefox 44
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(2 files)
4.41 KB,
patch
|
liuche
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1.78 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
We only had a single probe, setdefault.1, which tracking setting a default home panel. We should add probes for hide, show and remove. I suppose we could add a probe for a general move, but I don't know that up or down is needed.
Assignee | ||
Comment 1•6 years ago
|
||
This patch adds probes for HIDE, SHOW, MOVE and REMOVE Events. It also changes the text name of "setdefault.1" to "panel.setdefault.1" to match the convention used for "search.*.1" Events. Also uses DIALOG for the Method, like "search.*.1" does. I will update the analysis script to handle old "setdefault.1" -> "panel.setdefault.1" renames. I already do that for a few others. Tested and I see the right output in the logcat.
Assignee: nobody → mark.finkle
Attachment #8668259 -
Flags: review?(liuche)
Assignee | ||
Comment 2•6 years ago
|
||
This patch updates the docs to list the new Events.
Attachment #8668261 -
Flags: review?(liuche)
Comment 3•6 years ago
|
||
Comment on attachment 8668259 [details] [diff] [review] homepanel-settings-probes v0.1 Review of attachment 8668259 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. I wonder if people change their panel orders...
Attachment #8668259 -
Flags: review?(liuche) → review+
Updated•6 years ago
|
Attachment #8668261 -
Flags: review?(liuche) → review+
https://hg.mozilla.org/integration/fx-team/rev/dcbe3158d29d https://hg.mozilla.org/integration/fx-team/rev/bce73b114fdc
Comment 5•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcbe3158d29d https://hg.mozilla.org/mozilla-central/rev/bce73b114fdc
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8668259 [details] [diff] [review] homepanel-settings-probes v0.1 Approval Request Comment [Feature/regressing bug #]: None [User impact if declined]: We'd like to get more telemetry info [Describe test coverage new/current, TreeHerder]: Landed on Nightly and probes are reporting well. [Risks and why]: Low [String/UUID change made/needed]: None
Attachment #8668259 -
Flags: approval-mozilla-beta?
Attachment #8668259 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
status-firefox42:
--- → affected
status-firefox43:
--- → affected
Comment 7•6 years ago
|
||
Comment on attachment 8668259 [details] [diff] [review] homepanel-settings-probes v0.1 Sure, should be in 42 beta 6.
Attachment #8668259 -
Flags: approval-mozilla-beta?
Attachment #8668259 -
Flags: approval-mozilla-beta+
Attachment #8668259 -
Flags: approval-mozilla-aurora?
Attachment #8668259 -
Flags: approval-mozilla-aurora+
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b8cdb043ac3e https://hg.mozilla.org/releases/mozilla-aurora/rev/62ffae819bfb
Updated•2 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•