Closed Bug 1210283 Opened 4 years ago Closed 4 years ago

Add more UI Telemetry probes for managing Home Panels

Categories

(Firefox for Android :: Settings and Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(2 files)

We only had a single probe, setdefault.1, which tracking setting a default home panel. We should add probes for hide, show and remove. I suppose we could add a probe for a general move, but I don't know that up or down is needed.
This patch adds probes for HIDE, SHOW, MOVE and REMOVE Events. It also changes the text name of "setdefault.1" to "panel.setdefault.1" to match the convention used for "search.*.1" Events. Also uses DIALOG for the Method, like "search.*.1" does.

I will update the analysis script to handle old "setdefault.1" -> "panel.setdefault.1" renames. I already do that for a few others.

Tested and I see the right output in the logcat.
Assignee: nobody → mark.finkle
Attachment #8668259 - Flags: review?(liuche)
This patch updates the docs to list the new Events.
Attachment #8668261 - Flags: review?(liuche)
Comment on attachment 8668259 [details] [diff] [review]
homepanel-settings-probes v0.1

Review of attachment 8668259 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I wonder if people change their panel orders...
Attachment #8668259 - Flags: review?(liuche) → review+
Attachment #8668261 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/dcbe3158d29d
https://hg.mozilla.org/mozilla-central/rev/bce73b114fdc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8668259 [details] [diff] [review]
homepanel-settings-probes v0.1

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: We'd like to get more telemetry info
[Describe test coverage new/current, TreeHerder]: Landed on Nightly and probes are reporting well.
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8668259 - Flags: approval-mozilla-beta?
Attachment #8668259 - Flags: approval-mozilla-aurora?
Comment on attachment 8668259 [details] [diff] [review]
homepanel-settings-probes v0.1

Sure, should be in 42 beta 6.
Attachment #8668259 - Flags: approval-mozilla-beta?
Attachment #8668259 - Flags: approval-mozilla-beta+
Attachment #8668259 - Flags: approval-mozilla-aurora?
Attachment #8668259 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.