1210295 - Simplify TOK_DEFAULT case in Parser::exportDeclaration.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

https://dxr.mozilla.org/mozilla-central/rev/97e537f85183ef31481602ab9e5587a6e7d16b4d/js/src/frontend/Parser.cpp#4967
>        ParseNode* binding = nullptr;
>        switch (tt) {
>          case TOK_FUNCTION:
>            kid = functionStmt(YieldIsKeyword, AllowDefaultName);
>            break;
>          case TOK_CLASS:
>            kid = classDefinition(YieldIsKeyword, ClassStatement, AllowDefaultName);
>            break;
>          default:
>            tokenStream.ungetToken();
>            RootedPropertyName name(context, context->names().starDefaultStar);
>            binding = makeInitializedLexicalBinding(name, true, pos());
>            if (!binding)
>                return null();
>            kid = assignExpr(InAllowed, YieldIsKeyword);
>            if (kid) {
>                if (!MatchOrInsertSemicolonAfterExpression(tokenStream))
>                    return null();
>            }
>            break;
>        }
>        if (!kid)
>            return null();

It's a little confusing that placing |if (!kid)| after |if (kid)|.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Simplify TOK_DEFAULT case in Parser::exportDeclaration.

Moved |if (!kid)| to each case.

Comment 2

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/054abc8d92d84c5b7d840dffa1a471f580823d78
Bug 1210295 - Simplify TOK_DEFAULT case in Parser::exportDeclaration. r=Waldo

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/054abc8d92d8