1210308 - Bookmark tool bar presentation regressed with the gtk3 => gtk2

Status: RESOLVED DUPLICATE of bug 1210086

(Core :: Widget: Gtk, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: sc-bookmark.png

The texts are too close in the bookmark tool bar (cf screenshot)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Tracking as it is an obvious and visual regression.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Mouse over the various items in this tool bar has no effect either

Comment 3

[Lee Salzman [:lsalzman]]

Are you using any particular GTK3 theme other than the default? I tried reproducing this particular symptom by enabling the bookmarks toolbar and adding some bookmarks to it, but they appear appropriately spaced for me.

Comment 4

[Andrew Comminos [:acomminos]]

I'd imagine bug 1160154 might be relevant here, explaining why standard buttons wouldn't be affected.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

I am using gtk 2 and I don't have any theme (I am using awesome).
I didn't had this issue with 41 (or in 42.0 b1 when we had gtk 3).

Comment 6

[Andrew Comminos [:acomminos]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #5)
> I am using gtk 2 and I don't have any theme (I am using awesome).
> I didn't had this issue with 41 (or in 42.0 b1 when we had gtk 3).

So in this case, it looks like the fallback theme (Raleigh) that you're using doesn't have the same padding as Adwaita and other GTK themes for the image-button class;

> (from Adwaita's CSS)
> .button.image-button, GtkScaleButton.button,
> GtkVolumeButton.button, .header-bar .titlebutton.button,
> .titlebar .titlebutton.button {
>  padding: 8px; }

I'm thinking we should register our own style provider with priority GTK_STYLE_PROVIDER_PRIORITY_FALLBACK to provide fallback theme attributes for cases like this where we want a sensible default. Thoughts, Karl?

See:
https://developer.gnome.org/gtk3/stable/GtkStyleContext.html#gtk-style-context-add-provider
https://developer.gnome.org/gtk3/stable/GtkCssProvider.html#gtk-css-provider-new

Comment 7

[Karl Tomlinson (:karlt)]

This is an issue with the GTK2 port and so GTK3 theming is not involved.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Tracking in the other bug.