Remove support for line endings munging in the preprocessor

RESOLVED FIXED in Firefox 44

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8668336 [details] [diff] [review]
Remove support for line endings munging in the preprocessor

It was added back in
https://github.com/mozilla/gecko-dev/commit/5147d5c69fa5c53ea34e2872136bf55fc8c37664
for unclear reasons (and the lack of bug number doesn't help), and hasn't been
used, as far as I can see in the gecko-dev history, other than in bug 206029,
which is the only use currently in the tree.

Bug 206029 was working around the Flash player installer modifying Firefox's
prefs file and not dealing with it properly or something depending on the line
endings. 11 years later, all prefs files except channel-prefs.js are in
omni.ja, so obviously, bug 206029 doesn't actually apply anymore.

So, let's simplify it all and get rid of this.
Attachment #8668336 - Flags: review?(gps)
(Assignee)

Updated

2 years ago
Blocks: 1210642

Comment 2

2 years ago
Comment on attachment 8668336 [details] [diff] [review]
Remove support for line endings munging in the preprocessor

Review of attachment 8668336 [details] [diff] [review]:
-----------------------------------------------------------------

I'll joyfully r+ removing features.
Attachment #8668336 - Flags: review?(gps) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b5dc81ee578
https://hg.mozilla.org/mozilla-central/rev/6b5dc81ee578
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.