Closed
Bug 1210404
Opened 9 years ago
Closed 9 years ago
Ability to switch node.js version on CI machines
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: rickychien, Unassigned)
References
Details
As you may know, bug 955988 is working on node.js refactoring. Running build system on node.js will require latest jsdom [1] but it depends on node.js version >= 4.x. It would be a problem if we go to upgrade node.js to 4.x since integration test will break when node.js !== 0.10.x or !== 0.12.x Thus, I propose this solution by installing a nvm [2] for CI machines. I think it makes sense to switch 0.10.x or 0.12.x when running integration test and switch to 4.x when build-time. [1] https://github.com/tmpvar/jsdom [2] https://github.com/creationix/nvm
Reporter | ||
Comment 1•9 years ago
|
||
Gareth, do you have any suggestion how to do this? Do you think it makes sense to you if we go to install nvm on CI machines and it would be able to switch appropriate node version to build / run tests on Gaia. People will be notified that they must run on some specific node versions when trying to build or testing on local.
Flags: needinfo?(gaye)
Reporter | ||
Comment 2•9 years ago
|
||
Almost all node packages are upgraded to node 4+, so node switching solution is unnecessary right now.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(gaye)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•