1210409 - Robocop uses APIs that have been removed in API 23 / Android 6.0

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Build output:
https://pastebin.mozilla.org/8848058

* BaseRobocopTest uses org.apache.http
* testImportFromAndroid accesses removed methods in android.provider.Browser

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

I'll create a patch.

There's only one place where HttpClient is used and that's to just read the HTTP status code. I'll refactor this to use URLConnection.

For testImportFromAndroid: We had the same problem with Fennec's import. We inlined the fields that had been removed. I'll probably do the same here too.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Robocop: Use URLConnection instead of HttpClient

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: testImportFromAndroid: Inline functionality that has been in android.provider.Browser previously

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Together with other API 23 build patches:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93b51c8b5499

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8668552 [details] [diff] [review]
Robocop: Use URLConnection instead of HttpClient

This patch replaces the removed HttpClient with URLConnection.

gbrown, jmaher: I guess one of you would be the best to review this, right? Bugzilla refuses to add gbrown as reviewer. :)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8668554 [details] [diff] [review]
testImportFromAndroid: Inline functionality that has been in android.provider.Browser previously

Review of attachment 8668554 [details] [diff] [review]:
-----------------------------------------------------------------

I inlined the functionality of android.provider.Browser into the test. That's how we fixed the bookmark import in Fennec.

For reference:
* android.provider.Browser: http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/5.1.1_r1/android/provider/Browser.java#Browser
* android.provider.BrowserContract: http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/5.1.1_r1/android/provider/BrowserContract.java

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8668552 [details] [diff] [review]
Robocop: Use URLConnection instead of HttpClient

Review of attachment 8668552 [details] [diff] [review]:
-----------------------------------------------------------------

this looks reasonable.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8668554 [details] [diff] [review]
testImportFromAndroid: Inline functionality that has been in android.provider.Browser previously

Review of attachment 8668554 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the reference on this.  I assume this will work well for android 2.3 and 4.x?

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Joel Maher (:jmaher) from comment #8)
> thanks for the reference on this.  I assume this will work well for android
> 2.3 and 4.x?

Yeah. I pushed it to try with some other patches:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93b51c8b5499

This should even work on Android 6. The ContentProvider still exists but has been replaced with a dummy implementation that always returns an empty Cursor (to avoid crashing legacy apps). Just all public fields referencing this have been removed.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a2227abb5c3f
https://hg.mozilla.org/integration/fx-team/rev/f6282e823702

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2227abb5c3f
https://hg.mozilla.org/mozilla-central/rev/f6282e823702

Comment 12

[Geoff Brown [:gbrown] (pto Apr 11-18)]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> gbrown, jmaher: I guess one of you would be the best to review this, right?
> Bugzilla refuses to add gbrown as reviewer. :)

I disabled reviews since I was mostly offline during pto.

Landed patches look great - thanks!