Closed Bug 1210441 Opened 9 years ago Closed 9 years ago

ProxyAccessible::IsTable* should take tabular MathML accessibles into account.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8668513 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8668513 [details] [diff] [review]
Patch

>+  inline bool IsTable() const {

{ on new line please

>+  inline bool IsTableRow() const {

same

>+  inline bool IsTableCell() const {

same

>+    return mRole == roles::CELL || mRole == roles::MATHML_CELL;

btw that still misses header cells
Attachment #8668513 - Flags: review?(tbsaunde+mozbugs) → review+
Blocks: 1210477
Attached patch Patch V2Splinter Review
OK, I added COLUMNHEADER, ROWHEADER and GRID_CELL. I also added a reference to bug 1210477.
Attachment #8668513 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e75337909518
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: