1210457 - alert manager interface could use some quick cleanups for short term wins

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

1) the try syntax needs to be updated, we have different job names, e10s, etc.
2) link to alert manager shows the list of alerts, but the table view is easier to understand, add a "&table=1" to the end of the url
3) ignore improvements in the generated template

4/5) link to perfherder graphs/comparechooser. (re: bug 1150616)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

another nice thing would be to highlight if we have a 24 hour backout candidate and make it know (use the https://etherpad.mozilla.org/24-hour-backout-template template)

and while I am at it, lets add some more:
* update code for e10s, this isn't know very well, this would include templates, try jobs, parsing platforms
* update code for new jobs (like g3 is dromaeo now)

Comment 2

[MikeLing]

Hi Joel, I'm not fully understand the meaning of the try syntax. Could you tell me more about it? or just show me a link and document about it. Thank you!

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

MikeLing- great question, I will try to explain it better.

Try syntax is defined and can be generated/discovered here: http://trychooser.pub.build.mozilla.org/

In our template, we take a test name which failed (e.g. 'damp'), and need to translate that into a job name on try (e.g. 'g2').

Some changes to account for:
* if the platform has e10s in it, then we need to add a -e10s to the job name (e.g. g2-e10s)
* dromaeo_dom is in 'g3' (fix in https://github.com/jmaher/alert_manager/blob/master/managed_settings.py)

Comment 4

[MikeLing]

(In reply to Joel Maher (:jmaher) from comment #3)

> Some changes to account for:
> * if the platform has e10s in it, then we need to add a -e10s to the job
> name (e.g. g2-e10s)
> * dromaeo_dom is in 'g3' (fix in
> https://github.com/jmaher/alert_manager/blob/master/managed_settings.py)

Ok, I think I got the ideal how to start my work for this bug. I will take it after commit first patch. Oh, could you tell me more about those requirement in comment 0? I can't see they have any connection between those changes above(it's seems like a issue for alter manager rather than for perfherder)

Thank you :)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

yes, these are all features to add to alert manager, not perfherder.  I think in the near future (this week) when wlach has alerts going for perfherder, we can look at doing alert management work inside of perfherder.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

all that is left on perfherder alerts is to:
* ignore improvements in bug filing template
* add a link to a compare view automatically in the bug filing template

Comment 7

[William Lachance (:wlach)]

Is there anything left to do here?

(In reply to Joel Maher ( :jmaher) from comment #6)
> all that is left on perfherder alerts is to:
> * ignore improvements in bug filing template

If you meant in the title, this is already done.

> * add a link to a compare view automatically in the bug filing template

I think the summaries we now put in the bug cover this (probably better than using the compare view)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

all good!