1210467 - Exit build script if aws client fails

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Comment 1

[Wander Lairson Costa]

Attachment: Exit script if aws fails to list backup file. r=garndt

As the aws command line tool call is piped, its status is lost, but the
net result is an empty variable assigment. We take advantage of this to
detect errors in the aws tool.

Comment 2

[Greg Arndt [:garndt]]

Comment on attachment 8668553 [details] [diff] [review]
Exit script if aws fails to list backup file. r=garndt

Review of attachment 8668553 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/taskcluster/scripts/phone-builder/pre-build.sh
@@ +30,5 @@
>  if [ 0$B2G_DEBUG -ne 0 ]; then
>    debug_flag='--debug'
>  fi
>  
> +if ! aws --output=text s3 ls s3://b2g-phone-backups/$TARGET/; then

Hrm, does this work correctly for devices that dont' have a phone backup?

Comment 3

[Wander Lairson Costa]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6fdd2e6a142

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/19db5133d27c

Comment 5

[Wander Lairson Costa]

Backed out http://hg.mozilla.org/integration/b2g-inbound/rev/e843ef367f35.

Broke nexus. BTW, just saw there is no nexus device on try.

Comment 6

[Wander Lairson Costa]

Attachment: Exit script if aws fails to list backup file. r=garndt

Make a dummy call to aws client to make sure credentials are ok.

Comment 7

[Wander Lairson Costa]

Comment on attachment 8668645 [details] [diff] [review]
Exit script if aws fails to list backup file. r=garndt

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5037aec1237c

Nexus build:
https://tools.taskcluster.net/task-inspector/#XY1-rEMaTem424MzOuuc8g/

Failed build:
https://tools.taskcluster.net/task-inspector/#4hbmI_2XQsCX8gf1J0haaA/0

Comment 8

[Greg Arndt [:garndt]]

Comment on attachment 8668645 [details] [diff] [review]
Exit script if aws fails to list backup file. r=garndt

Review of attachment 8668645 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 9

[Greg Arndt [:garndt]]

r+ as long as this line won't cause issue if the backup doesn't exist:

 backup_file=$(aws --output=text s3 ls s3://b2g-phone-backups/$TARGET/ | tail -1 | awk '{print $NF}')

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/48ea67571aac

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/48ea67571aac