1210487 - log viewer: selected lines don't always scroll to view on initial page load

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Cameron Dawson [:camd]]

Hit this with:
https://treeherder.mozilla.org/logviewer.html#?job_id=15058748&repo=mozilla-inbound#L142-L143

It should bring line 142 into view on first page load, but it's off screen

Comment 1

[Cameron Dawson [:camd]]

Hey Goma: if you get any time, would you be up for looking into this?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

As a guess, since it didn't pre-load the failure chunk (since it didn't parse a failure out of the raw log), it didn't jump to the selected line?

Comment 3

[Gabriel Machado [:goma]]

https://github.com/mozilla/treeherder/blob/master/ui/partials/logviewer/lvLogSteps.html#L24
The scroll function is called only in error cases. 

I can work on this. :)

Comment 4

[Gabriel Machado [:goma]]

Attachment: Link to Github Pull Request

I tested for a while. It seems that it's working fine now.

Comment 5

[Cameron Dawson [:camd]]

Thanks!  I'll review this first thing tomorrow morning.

Comment 6

[Cameron Dawson [:camd]]

Dang, I won't have time this morning before I head to my Dr. appt.  I'll hopefully get to this this afternoon.

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8668664 [details] [review]
Link to Github Pull Request

Goma--  The fix works great!  Thanks!  But would you be able to do the minor code-cleanup I mentioned in the review.  Then I can merge this.

Thanks for the quick turn-around!  :)

Comment 8

[Gabriel Machado [:goma]]

Hey Camd. I've changed it on github, I don't know if you saw it.
I've been facing some problems with my internet last week, and I'll move on to another city next week. But as soon as everything is fine, I'd like to work on the 'loading data from pulse' that you told me on Irc.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/fb70245edd22ca7c340dcb3d4860b99df8cb0ec6
Bug 1210487 - log viewer: selected lines don't always scroll to view on initial page load

https://github.com/mozilla/treeherder/commit/c8a966dc94a28c13551531e3f269e0b369b100ae
Merge pull request #1026 from gbrmachado/Bug-1210487

Bug 1210487 - log viewer: selected lines don't always scroll to view …

Comment 10

[Cameron Dawson [:camd]]

Thanks Gabriel!  Great work!  I merged this just now.  So it should go to stage, and then production on our next set of pushes.

I look forward to chatting with you more about the pulse stuff.  :)