1210493 - layout/reftests/pagination/abspos-breaking-007.html fails under Skia due to drawRect ignoring line width when culling strokes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Lee Salzman [:lsalzman]]

layout/reftests/pagination/abspos-breaking-007.html tests CSS border drawing while paginating. This causes strokeRects to be issued that are partially clipped.

However, inside SkDraw::drawRect, when doing a quick rejection on the rectangle's bounds, Skia does not enlarge the bounding rectangle by the line width of the stroke. This causes the bounding rectangle not to overlap the clip area, and so the stroke is rejected and the test fails.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: enlarge stroke bounds by line width when doing a quick-reject in SkDraw::drawRect

This is just a straight backport of the latest Skia code that already fixed this issue by appropriately enlarging stroke bounding box with the stroke's width.

It fixes the failure with this particular reftest until we can do a full Skia upgrade in the future.

Since this is already upstream, it will not pose any difficulties on future upgrades.

Comment 2

[Lee Salzman [:lsalzman]]

Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b831db9a1656

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb52856f029c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb52856f029c