Closed Bug 1210549 Opened 4 years ago Closed 4 years ago

Fix retrieval of proxied accessibles from events on Windows

Categories

(Core :: Disability Access APIs, defect)

x86
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: Jamie, Unassigned)

References

Details

Attachments

(3 files, 1 obsolete file)

With e10s enabled, events are now fired for proxied accessibles on Windows, but retrieving the accessibles fails. IAccessible::accChild returns E_INVALIDARG.
Attachment #8668650 - Flags: review?(tbsaunde+mozbugs)
Attachment #8668648 - Flags: review?(tbsaunde+mozbugs)
Blocks: e10sa11y2
Attachment #8668651 - Flags: review?(tbsaunde+mozbugs) → review+
Attachment #8668648 - Flags: review?(tbsaunde+mozbugs) → review+
Comment on attachment 8668650 [details] [diff] [review]
Fix AccessibleWrap::GetXPAccessibleFor for proxied accessibles.

I'm kind of crazy, but I'd probably break these up into separate patches.

also we shouldn't land this part till the ipc reentering stuff is fixed.

>+    if (doc == this) {
>+      AccessibleWrap* proxyWrapper =
>+        GetProxiedAccessibleInSubtree(remoteDocs->ElementAt(i), id);
>+      if (proxyWrapper) {
>+        return proxyWrapper;
>+      }
>+      continue;

nit, blank line after } please
Attachment #8668650 - Flags: review?(tbsaunde+mozbugs) → review+
Aside from fixing the nit, this version also fixes the case where one tries to retrieve a proxied child (c) of a proxied document (d) where accChild is called on the document itself (d).

I'm happy to split these into separate patches if you wish, though it's difficult to come up with summaries for each patch. Also, I don't think it would make sense for these to land separately if that were to happen for whatever reason.
Attachment #8668650 - Attachment is obsolete: true
Attachment #8668871 - Flags: review?(tbsaunde+mozbugs)
Ping! Now that bug 1212906 is fixed, can this be landed or is further work required?
Depends on: 1212906
(In reply to James Teh [:Jamie] from comment #6)
> Ping! Now that bug 1212906 is fixed, can this be landed or is further work
> required?

I was planning on landing it tomorrow :)
Attachment #8668871 - Flags: review?(tbsaunde+mozbugs) → review+
You need to log in before you can comment on or make changes to this bug.