1210549 - Fix retrieval of proxied accessibles from events on Windows

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

With e10s enabled, events are now fired for proxied accessibles on Windows, but retrieving the accessibles fails. IAccessible::accChild returns E_INVALIDARG.

Comment 1

[James Teh [:Jamie]]

Attachment: Make proxied accessibles defunct when proxy dies.

Comment 2

[James Teh [:Jamie]]

Attachment: Fix AccessibleWrap::GetXPAccessibleFor for proxied accessibles.

Comment 3

[James Teh [:Jamie]]

Attachment: Allow IServiceProvider::QueryService to work for proxied accessibles (needed to use IA2).

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8668650 [details] [diff] [review]
Fix AccessibleWrap::GetXPAccessibleFor for proxied accessibles.

I'm kind of crazy, but I'd probably break these up into separate patches.

also we shouldn't land this part till the ipc reentering stuff is fixed.

>+    if (doc == this) {
>+      AccessibleWrap* proxyWrapper =
>+        GetProxiedAccessibleInSubtree(remoteDocs->ElementAt(i), id);
>+      if (proxyWrapper) {
>+        return proxyWrapper;
>+      }
>+      continue;

nit, blank line after } please

Comment 5

[James Teh [:Jamie]]

Attachment: Fix AccessibleWrap::GetXPAccessibleFor for proxied accessibles (version 2).

Aside from fixing the nit, this version also fixes the case where one tries to retrieve a proxied child (c) of a proxied document (d) where accChild is called on the document itself (d).

I'm happy to split these into separate patches if you wish, though it's difficult to come up with summaries for each patch. Also, I don't think it would make sense for these to land separately if that were to happen for whatever reason.

Comment 6

[James Teh [:Jamie]]

Ping! Now that bug 1212906 is fixed, can this be landed or is further work required?

Comment 7

[Trevor Saunders (:tbsaunde)]

(In reply to James Teh [:Jamie] from comment #6)
> Ping! Now that bug 1212906 is fixed, can this be landed or is further work
> required?

I was planning on landing it tomorrow :)

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d09d65a73f
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c948f1d2096
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8eb48dac54

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2d09d65a73f
https://hg.mozilla.org/mozilla-central/rev/1c948f1d2096
https://hg.mozilla.org/mozilla-central/rev/6e8eb48dac54