Closed Bug 1210606 Opened 9 years ago Closed 8 years ago

share pointer from standalone to desktop

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
5

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Iteration:
47.2 - Feb 22

People

(Reporter: Mardak, Assigned: fcampo)

References

Details

(Whiteboard: [pointer])

User Story

As a desktop client user I see the link clicker user's pointer, so that we can discuss what she is pointing at.

- Desktop client user can see the link clicker's pointer
--- The link clicker's pointer is shown per its X/Y position on the original page if the link clicker has his browser (window where tab sharing is enabled) in the foreground
--- The link clicker's pointer remains on the last recorded position if the link clicker has his browser in the background (window where tab sharing is enabled) or is on another tab
--- Less than 200ms delay between a change of position from the link clicker and its display on the link generator side
--- When tab sharing is enabled, the link clicker's pointer is automatically shared if it's on the page

- Pointer colors match the text chat speech bubble colors
--- The local user pointer's color remains unchanged
--- The remote user pointer's color matches the color of the link clicker's text chat speech bubble color  

== Tech Checklist ==
* see pull request prototype with notes <https://github.com/dmose/gecko-dev/pull/15/files>
* reuse API from bug 1210588 to communicate cursor coordinates
* detect cursor movement in standalone via shared MediaView
-- https://github.com/dmose/gecko-dev/pull/15/files#r40969397
-- make sure coordinates are relative to the rendered video (instead of window/letterbox that's part of the <video> element)
* on receiving cursor coordinates, pass to chrome to render cursor
-- https://github.com/dmose/gecko-dev/pull/15/files#diff-e43568e556255552629c2b3f532ec4caR758
-- https://github.com/dmose/gecko-dev/pull/15/files#r40969845
* use appropriate pointer colors

Attachments

(1 file)

[loop] fcampo:shared-stand-to-desktop-1210606 > mozilla:master
40 bytes, text/x-github-pull-request
Mardak
: review+
Details | Review 
      No description provided.
Points: --- → 5
Rank: 25
Priority: -- → P2
Whiteboard: [websharing, pointer]
Rank: 25 → 29
Rank: 29 → 23
Rank: 23 → 19
Priority: P2 → P1
Rank: 19 → 15
Assignee: nobody → fernando.campo
Whiteboard: [websharing, pointer] → [pointer]
Attachment #8716802 - Flags: review?(standard8)
Attachment #8716802 - Flags: review?(edilee)
Attachment #8716802 - Flags: review?(b.mcb)
Comment on attachment 8716802 [details] [review]
[loop] fcampo:shared-stand-to-desktop-1210606 > mozilla:master

r=Mardak Addressing comments: Main thing is simplifying with the singleton #loop-remote-cursor and listenTo for store change: event.
Attachment #8716802 - Flags: review?(standard8)
Attachment #8716802 - Flags: review?(edilee)
Attachment #8716802 - Flags: review?(b.mcb)
Attachment #8716802 - Flags: review+
Comments addressed, tests green, ready for merging.
Kudos to Ed for the quick review.
Keywords: checkin-needed
Fernando: I've merged this for you, but you should be able to do it yourself, I believe you should have permissions, if not let me know. Best way of landing is like this: https://github.com/mozilla/loop/blob/master/CONTRIBUTING.md#landing at it avoids merge commits.

https://github.com/mozilla/loop/commit/f7b3a483a0859a53c31923023cfb5a3546519c0e
https://github.com/mozilla/loop/commit/5e284e5ace41d064a4d06d7e726e8d33d769052a
https://github.com/mozilla/loop/commit/48085d0a560996d51ea3b7edd59e2d0b1f419dbd
https://github.com/mozilla/loop/commit/a3777f33612ec17c3f9653870cf5bfb28b24259c
Status: NEW → RESOLVED
Iteration: --- → 47.2 - Feb 22
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Thought that autolander would take care of that with the [checkin-needed tag
Sorry! if I knew it would have to be manual I'd do it myself
Blocks: 1248530
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: