Closed Bug 1210608 Opened 7 years ago Closed 7 years ago

[Music][NGA] Perf regression using 'caching' attribute in <gaia-fast-list>

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

Details

Attachments

(1 file)

In Bug 1209477, the A-Z picker was added to <gaia-fast-list>. In addition, the `[caching]` attribute was added which uses `localStorage` and causes a major delay in the initial loading of the view, presumably because `localStorage` blocks the main thread. The `[caching]` attribute should be removed until this feature is improved.
Assignee: nobody → jdarcangelo
Attachment #8668701 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8668701 [details] [review]
[gaia] justindarc:bug1210608 > mozilla-b2g:master

A quick r=me so we don't anger the spirit of Andreas.
Attachment #8668701 - Flags: review?(squibblyflabbetydoo) → review+
Wilson: Just a heads up. The use of `localStorage` here was actually having severe negative consequences on the loading performance of the views. Please take a look and see if there's any way to make the <gaia-fast-list> caching async so it doesn't block.
Flags: needinfo?(wilsonpage)
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/abba7d1f50ecc2379b780a0a6dfe34a4575e6cba
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
We tried IndexedDB for this caching solution but it took just as long to retrieve data and had the downside of showing a blank list before we got the data back and were able to paint content.
Flags: needinfo?(wilsonpage)
justindarc: Do you know roughly how long the localStorage call was taking?
As I recall, one of the issues with localStorage is that, in addition to being fairly slow, it's also on the main thread, which means the UI is hung while a query is running.
You need to log in before you can comment on or make changes to this bug.