1210608 - [Music][NGA] Perf regression using 'caching' attribute in <gaia-fast-list>

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

In Bug 1209477, the A-Z picker was added to <gaia-fast-list>. In addition, the `[caching]` attribute was added which uses `localStorage` and causes a major delay in the initial loading of the view, presumably because `localStorage` blocks the main thread. The `[caching]` attribute should be removed until this feature is improved.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1210608 > mozilla-b2g:master

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8668701 [details] [review]
[gaia] justindarc:bug1210608 > mozilla-b2g:master

A quick r=me so we don't anger the spirit of Andreas.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Wilson: Just a heads up. The use of `localStorage` here was actually having severe negative consequences on the loading performance of the views. Please take a look and see if there's any way to make the <gaia-fast-list> caching async so it doesn't block.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/abba7d1f50ecc2379b780a0a6dfe34a4575e6cba

Comment 5

[Wilson Page [:wilsonpage]]

We tried IndexedDB for this caching solution but it took just as long to retrieve data and had the downside of showing a blank list before we got the data back and were able to paint content.

Comment 6

[Wilson Page [:wilsonpage]]

justindarc: Do you know roughly how long the localStorage call was taking?

Comment 7

[Jim Porter (:squib)]

As I recall, one of the issues with localStorage is that, in addition to being fairly slow, it's also on the main thread, which means the UI is hung while a query is running.