Closed
Bug 1210673
Opened 9 years ago
Closed 9 years ago
use dialog service to show media storage dialogs
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
FIXED
| tracking-b2g | backlog |
People
(Reporter: gasolin, Assigned: ralin)
References
Details
(Whiteboard: [good first bug][mentor-lang=zh][lang=js])
Attachments
(1 file)
In media storage, We'd use dialog service to show the dialog instead of current html dialog in media_storage.html
|
Reporter | |
Updated•9 years ago
|
tracking-b2g:
--- → backlog
|
|
Reporter | |
Comment 1•9 years ago
|
||
could refer Bug 1203038 to replace HTML dialog with DialogService
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
|
||
Comment 2•9 years ago
|
||
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8693466 [details] [review] [gaia] raylin:1210673-media-storgae-to-dialog-service > mozilla-b2g:master Hi, 1. deleted form from HTML 2. changed to dialog service approach 3. tested three functions with z3c & a 16GB sdcard I think we could file another bug to refactor to ES6 later, for more thorough test. Thanks,
Attachment #8693466 -
Flags: review?(gasolin)
|
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → ralin
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8693466 [details] [review] [gaia] raylin:1210673-media-storgae-to-dialog-service > mozilla-b2g:master Thanks for the patch, please address issues in github and set review again. Since there's no unit test for media_storage, remember to test on device for both ok and cancel cases.
Attachment #8693466 -
Flags: review?(gasolin)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8693466 [details] [review] [gaia] raylin:1210673-media-storgae-to-dialog-service > mozilla-b2g:master Hi Fred, I've updated PR. Could you review it again, thanks.
Attachment #8693466 -
Flags: review?(gasolin)
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8693466 [details] [review] [gaia] raylin:1210673-media-storgae-to-dialog-service > mozilla-b2g:master Looks good with 1 nit, please address it before merge Thanks!
Attachment #8693466 -
Flags: review?(gasolin) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/6f9870a533aceb0a91582a430676f89670b58e8a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•