1210707 - Feedback view no longer allows closing the window and avoiding leaving feedback

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

STR:

1) With a fresh profile, or with loop.feedback.dateLastSeenSec cleared, start a two-way conversation.
2) Exit the conversation on the desktop client.

=> Feedback view is shown.

3) Click the leave button again to avoid leaving feedback

Actual Results

=> Nothing happens

Expected Results

=> The conversation window is closed.

Comment 1

[Mark Banner (:standard8)]

Attachment: Feedback view no longer allows closing the window and avoiding leaving feedback.

We missed a case, thankfully the fix is quite simple.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8669582 [details] [diff] [review]
Feedback view no longer allows closing the window and avoiding leaving feedback.

Review of attachment 8669582 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, thanks! And a test - me gusta! :)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/be2e4d37fbc2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be2e4d37fbc2

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8669582 [details] [diff] [review]
Feedback view no longer allows closing the window and avoiding leaving feedback.

Approval Request Comment
[Feature/regressing bug #]: Bug 1184921 (approval reqd for 43)
[User impact if declined]: The user won't be able to close the conversation window when the feedback request is displayed, unless they select the leave feedback option.
[Describe test coverage new/current, TreeHerder]: Landed in m-c with unit tests.
[Risks and why]: Low, handles a missing case.
[String/UUID change made/needed]: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8669582 [details] [diff] [review]
Feedback view no longer allows closing the window and avoiding leaving feedback.

Fixes recent regression, needs to uplift to aurora along with 1184921

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/46a2fa2a827f