121072 - Missing plug-in name in "Illegal Operation" alert

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Henrik Gemal]

If you go to:
http://www.dse.nl/~sjonnie/manta.htm
you get a plug-in error.

Is this dialog there are two errors:
1. The plug-in name is missing.
2. Plug-in is spelled "plug-in" not "plugin". See bug 106413.

So I expect the dialog be redone to something like this:
"The QuickTime plug-in performed an illegal operation. You are strongly advised
to restart Navigator."

20020119

Comment 1

[av (gone)]

Is not "plug-in" correct spelling according to bug 106413?

nsPluginHostImpl::HandleBadPlugin method takes a handle to dll as a parameter 
which was originally supposed to be used to retrieve all necessary plugin info. 
So, to fix this should not be that difficult.

Comment 2

[av (gone)]

Attachment: patch v.1

The simplest fix I came with. With this patch you will see the name of the
plugin (as it is specified by the plugin manufaturer and seen in about:plugins)
followed by two line feeds and the old message.

Comment 3

[av (gone)]

Attachment: Screen shot of how it looks with the patch

Comment 4

[av (gone)]

Attachment: patch v.2

Minor improvement: more appropriate string manipulation.

Please review.

Comment 5

[serge (gone)]

Comment on attachment 65926 [details] [diff] [review]
patch v.2

r=serge

Comment 6

[Henrik Gemal]

av: this is sooo cool! thanx!

Comment 7

[Henrik Gemal]

any chance this could get a sr and checkin? We have a patch and r=

Comment 8

[Patrick C. Beard]

Comment on attachment 65926 [details] [diff] [review]
patch v.2

sr=beard

Comment 9

[av (gone)]

Checked in. Marking fixed.

Comment 10

[shrirang khanzode]

vf