Closed
Bug 1210749
Opened 10 years ago
Closed 9 years ago
NS_ReleaseOnMainThread and NS_ProxyRelease should take already_AddRefed instead of smart pointers
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
DUPLICATE
of bug 1164581
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | affected |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Depends on 1 open bug)
Details
NS_ReleaseOnMainThread should take already_AddRefed instead of smart pointers to reduce risks like what I mentioned in bug 1210747.
| Assignee | ||
Updated•10 years ago
|
Summary: NS_ReleaseOnMainThread should take already_AddRefed instead of smart pointers → NS_ReleaseOnMainThread and NS_ProxyRelease should take already_AddRefed instead of smart pointers
| Assignee | ||
Comment 1•10 years ago
|
||
This change would also benefit from static analysis on Move semantics I proposed in bug 1186706.
| Assignee | ||
Comment 2•10 years ago
|
||
I want to use the LeakPtr class I created in bug 1186745.
Assignee: nobody → quanxunzhen
Depends on: 1186745
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
| Assignee | ||
Comment 6•10 years ago
|
||
| Assignee | ||
Comment 7•10 years ago
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•