1210871 - don't use reinterpret_cast in nsTHashtable.h

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

We don't need to reinterpret_cast when casting from void*, and we don't
need to reinterpret_cast when we're casting up and down a class
hierarchy.  static_cast takes care of those cases just fine, and doesn't
scare the reader into thinking that nsTHashtable is doing something
unusual.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't use reinterpret_cast in nsTHashtable.h

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8669036 [details] [diff] [review]
don't use reinterpret_cast in nsTHashtable.h

Review of attachment 8669036 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming KeyTypePointer is required to actually be a pointer.

::: xpcom/glue/nsTHashtable.h
@@ +357,5 @@
>  template<class EntryType>
>  PLDHashNumber
>  nsTHashtable<EntryType>::s_HashKey(PLDHashTable* aTable, const void* aKey)
>  {
> +  return EntryType::HashKey(static_cast<const KeyTypePointer>(aKey));

Is it possible that KeyTypePointer could be defined as uintptr_t or some such (thus requiring the reinterpret_cast)? That seems unlikely, so if we just say that's not allowed it seems fine.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b186b6c5559

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0b186b6c5559