1210912 - fix widget leak in LookupRegisteredPluginWindow

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Nathan Froyd [:froydnj]]

nsRefPtrHashtable::Get follows XPCOM outparam rules, so it addrefs its
argument prior to returning it.  LookupRegisteredPluginWindow, however,
doesn't know anything about the additional reference, and neither does
anything else that calls it (which is, fortunately, not that much code).
So every widget returned by this function will leak.

To fix this, we use nsRefPtrHashtable::GetWeak, which doesn't addref its
argument, but merely returns the raw pointer, leaving the hashtable
responsible for the owning reference.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix widget leak in LookupRegisteredPluginWindow

I *think* this is a real leak, though I find it a little difficult to imagine
that our tests haven't caught this...

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e54d330a1de6

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e54d330a1de6