Closed Bug 1210924 Opened 9 years ago Closed 9 years ago

Add an operator bool to ReadBarriered

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Observing the boolean value of the pointer is not a read of the target of the pointer. Or at least it shouldn't be. The fact that it is means we have a bunch of maybeUnbarrieredThing() scattered all over in bool context.

Here is a try run to see what the truth looks like:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3b160675719

Assuming the above try run is green, I'd like to remove this footgun.
Attachment #8669103 - Flags: review?(sphink)
Comment on attachment 8669103 [details] [diff] [review]
add_bool_operator_to_ReadBarriered-v0.diff

Review of attachment 8669103 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this seems to be a very good change. :-)
Attachment #8669103 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/ab0182f2b70e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: