1210930 - "Back" button is not shown in the Private Mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Max Ivanov[:MaxIvanov]]

Description:
"Back" button works but not showed up when user use the browser in the private mode

Repro Steps:
1) Update a Aries to 20151002110616
2) Launch the Browser and open new private window 
3) Navigate any page 
4) Tap on any link

Actual:
"Back" button is not showed

Expected:
"Back" button should be showed next to address bar

Environmental Variables:
Device: Aries Master
Build ID: 20151002110616
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: af01a617cb76f0ced4e33f82a9567bbba44b9f24
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0


Repro frequency: (100%)
See attached: (screenshot)

Comment 1

[Max Ivanov[:MaxIvanov]]

This issue DOES occur on Aries 2.5 and Flame 2.5 and DOES NOT on Flame 2.2 
Result: "Back" button is not showed

Device: Aries Master
Build ID: 20151002110616
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: af01a617cb76f0ced4e33f82a9567bbba44b9f24
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
--------------------------------------------------------------------

Device: Flame Master Kk Full flash (319mb)
Build ID: 20151002025740
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: 5f16c6c2b969f70e8da10ee34853246d593af412
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
-----------------------------------------------------------------------

Device: Flame 2.2 Kk Full flash (319mb)
Build ID: 20151002032503
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: 2ab95b3d02a7
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Max Ivanov[:MaxIvanov]]

Attachment: 2015-10-02-12-21-47.png

Comment 3

[Martijn Wargers (dead)]

This works for me, using:
Build ID               20151001150204
Gaia Revision          bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gaia Date              2015-10-01 06:59:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2c1fb007137dcb68b1862a79553b53f1a34c99c3
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151001.182807
Firmware Date          Thu Oct  1 18:28:19 EDT 2015
Bootloader             L1TC000118D0

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Comment 5

[Mahendra Potharaju [:mahe]]

Blocks 2.5 with P2 priority. Needs to be fixed.

Comment 6

[John Thomas [:Johnt]]

B2g Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20151001104128
Gaia: c9bd0434942941f09d7b62dee715a87bfdcd811e
Gecko: b0b053cb93e554b0b0dc8060d8aa3e01c993b096
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20151001110326
Gaia: b4faf783aa6ea63eb2393ea15d403bb964cb4085
Gecko: ed833afe16580afa00d165b32aeacc83da3587e8
Version: 44.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Last Working gaia / First Broken gecko - This issue 
Gaia: c9bd0434942941f09d7b62dee715a87bfdcd811e
Gecko: ed833afe16580afa00d165b32aeacc83da3587e8

Last Working gecko / First Broken gaia - This issue DOES occur with broken gaia.
Gecko: b0b053cb93e554b0b0dc8060d8aa3e01c993b096
Gaia: b4faf783aa6ea63eb2393ea15d403bb964cb4085

B2g Inbound Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/c9bd0434942941f09d7b62dee715a87bfdcd811e...b4faf783aa6ea63eb2393ea15d403bb964cb4085

This issue is caused by Bug 1208170

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fabien the changes for bug 1208170 seem to have caused this issue.  Can you please take a look?

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1210930-back-button-image-missing > mozilla-b2g:master

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8670412 [details] [review]
[gaia] Phoxygen:bug1210930-back-button-image-missing > mozilla-b2g:master

redirecting

Comment 11

[Alberto Pastor [:albertopq]]

Comment on attachment 8670412 [details] [review]
[gaia] Phoxygen:bug1210930-back-button-image-missing > mozilla-b2g:master

Is not any of our Gij tests checking this? Would you mind to add a UI test that fails with current master but passes with your patch? r=me with that. Thanks!

Comment 12

[Reza Akhavan [:jedireza]]

PR already created in bug 1213898

Comment 13

[pelloux]

(In reply to Reza Akhavan [:jedireza] from comment #12)
> PR already created in bug 1213898

This bug also has the trivial PR attached.
I spent some time last week trying to build the UI test requested by Alberto in comment 11 - hopefully I can update the PR today.

Comment 14

[Reza Akhavan [:jedireza]]

Ah, thanks for clarifying Pierre Eric :) I was reading fast and overlooked that.

Comment 15

[pelloux]

PR updated, with a test for the back button.
I can add a similar one for the forward button but I'd like some feedback on the code first. 
Alberto would you mind taking a look at it?

Comment 16

[Alberto Pastor [:albertopq]]

Hey Pierre! I cannot see the test. Could you please point me to it? Thanks!

Comment 18

[pelloux]

Sorry, pushed to the wrong repository...
Mistake corrected: you can now see the test in the PR.

Comment 19

[Alberto Pastor [:albertopq]]

The test looks great to me! Thanks for adding it :)

Comment 20

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/8ea9029190

Comment 21

[Nigel Babu [:nigelb]]

This test is now perma-orange. Can someone look into this urgently? I'll probably have to close gaia until this can be sorted out.

Comment 22

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: "Back" button is shown next to address bar.
See attachment: verified_Aries_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20151018150205
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151018.183443
Firmware Date          Sun Oct 18 18:34:55 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1

Comment 23

[Shally Li（leave from Mozilla）]

Attachment: verified_Aires_v2.5.png