1210953 - hg pull -r <foo> try should never fetch the try pushlog

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[:Gijs (he/him)]

gkruitbosch-16516:fx-team gkruitbosch$ hg pull -r  1745b603a37d try
pulling from try
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 1 changes to 3 files (+1 heads)
fetching pushlog

<looooong pause>

(run 'hg heads' to see heads, 'hg merge' to merge)


I don't know why it's doing this and I can't think of a good reason. Can we make an exception for try?

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1210953 - don't fetch pushlog for try, r?gps

Bug 1210953 - don't fetch pushlog for try, r?gps

Comment 2

[:Gijs (he/him)]

I have no idea if this change is enough, I just went off where the "fetching pushlog" thing came from. Happy to adjust the patch given pointers to where I *should* be making this change.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8690194 [details]
MozReview Request: Bug 1210953 - don't fetch pushlog for try, r?gps

https://reviewboard.mozilla.org/r/25791/#review23403

I'm not a super huge fan of this exception: I'd like us to capture the pushlog for every repo we pull from. However, there is a real performance issue and this is the most appropriate workaround at this time.

Comment 4

[:Gijs (he/him)]

I'm assuming this is enough:

remote:   https://hg.mozilla.org/hgcustom/version-control-tools/rev/044353792af5