_peer Connection _basic H264Video .html | application crashed [@ mozilla::Webrtc Gmp Video Encoder::Encode _g(webrtc::I420Video Frame const*, webrtc::Codec Specific Info const*, std::vector<webrtc::Video Frame Type, std::allocator<webrtc::Video Frame Ty
Component: WebRTC → Audio/Video: MSG/cubeb/GMP
I don't know of a dupe. You're hitting Unexpected VideoFrameType here: https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp#130 That's not code media playback ever hits.
(In reply to Chris Pearce (:cpearce) from comment #2) > I don't know of a dupe. > > You're hitting Unexpected VideoFrameType here: > > https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/ > media-conduit/WebrtcGmpVideoCodec.cpp#130 > > That's not code media playback ever hits. Thanks. And looking over that code it seems pretty impossible; Encode() in generic_encoder in webrtc.org is preceded by ConvertFrameType, which asserts on anything that isn't a key or delta frame. The initialization of nextFrameTypes in video_sender.cc is wrong ("1, kVideoFrameDelta" - 1 is kAudioFrameSpeech, but that should trigger an assert() when converted -- and if it doesn't, it'll end up Delta anyways. And in GMP, Encode() dispatches Encode_g() via DISPATCH_SYNC. So this should be truly impossible.
backlog: --- → webrtc/webaudio+
Priority: -- → P3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.