Closed Bug 121100 Opened 23 years ago Closed 22 years ago

quick launch (turbo) not persistent during crash ( fails to reload after crash)

Categories

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Product:
Core Graveyard
Component:
QuickLaunch (AKA turbo mode)
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME
Milestone:
mozilla1.1alpha

People

(Reporter: patrick.hendriks+bugzilla, Assigned: law)

References

Details

(Whiteboard: [adt2 rtm]) 

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.7+)
Gecko/20020121
BuildID:    2002012103

I'm running mozilla with QuickLaunch (Turbo) enabled. Now if mozilla crashes all
windows close, and the icon is removed from the system tray, as it should. If i
then start mozilla again, the tray icon doesn't reappear and QuickLaunch is not
enabled. However, going to ADVANCED in preferences, you'll see that the box is
still checked, but only as soon as you click OK, QuickLaunch is TRULY enabled,
and the tray icon appears again

Reproducible: Always
Steps to Reproduce:
1.enable quicklauch
2.crash mozilla
3.restart mozilla
4. go to preferences advanced, notice the box for Turbo mode is checked
5. only when clicking OK the Turbo mode is truly activated (watch the sys tray
icon appear)

Actual Results:  relaunch should re-anable quicklaunch

Expected Results:  relaunch did not re-enable quicklaunch, even though box is
still checked.
-> QuickLaunch
Assignee: asa → law
Component: Browser-General → QuickLaunch (AKA turbo mode)
QA Contact: doronr → gbush
Are you turning QuickLaunch on in the same session that is crashing?  Maybe
we're not flushing some necessary pref values.  Can you try turning it on,
closing all windows and exiting Mozilla.  Start again, cause a crash, and see if
it still happens?
i enable QuickLaunch by default (i check the box during installation). 
Every once in a while (but not necessarily the first Mozilla session), Mozilla 
crashes.

If relaunched again, the QuickLaunch button is checked, but no sys-tray icon 
appears and when closing the newly launched Mozilla window, all mozilla 
processes are terminated. 

So i don't think it is related to newly checked boxes.
Putting off till mozilla1.0.1
Target Milestone: --- → mozilla1.1
I cannot reproduce here with Mozilla (1/29 build) or N6.2.1+ 
Icon always reappears 
Please confirm for Windows XP. I noticed this too.

patrick: I disagree with "Now if mozilla crashes all
windows close, and the icon is removed from the system tray, as it should", as I
was working on bug 100846 today, and I wasn't able to test it because Mozilla
was crashing on shutdown. The quicklaunch icon should be there independantly of
Mozilla, and not disappear when Mozilla crashes. I am rebuilding from today's
code to see if Mozilla won't crash on shutdown.

I also noticed that the first time you start Mozilla, the icon doesn't appear in
the taskbar (on my build at least - which is from yesterday) even though
Quicklaunch was enabled in prefs. I also noticed that on crash, the icon didn't
reappear when you restart Mozilla.

I put a call to ::MessageBox in MessageWindow::WindowProc
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsNativeAppSupportWin.cpp#808

for the msg WM_CREATE and it was called on startup, as the message box appeared.
Therefore, it seems that the dummy window is created, but that the icon isn't
added to the tray. I haven't investigated this further.

Is there currently a bug about isolating the quicklaunch icon from the rest of
the mozilla threads so it doesn't dissappear on crash?



i'm not sure if i agree with your statement "The quicklaunch icon should be
there independantly of Mozilla, and not disappear when Mozilla crashes" 

I think if you terminate the mozilla.exe process (either manually or by crashing
mozilla) you'll also kill the tray icon. You might need to hover over the system
tray for it to update itself (and make mozilla disappear).
I realize what does happen. The icon dissappears because its part of the Mozilla
process. What should happen is that there is a separate process that contains
the icon stays open even when mozilla crashes.

Should is the operative word here.  It is used to express obligation or duty. It
doesn't depend on the current state of affairs.

This separate process should occasionally check the libraries that are kept open
when Mozilla closes. If Mozilla crashes, those libraries will be closed, and the
icon process will detect it and reopen those libraries. The icon process should
be extremely stable.

Mozilla crashing shouldn't affect whether Mozilla is able to be quickly launched
or  make the icon dissappear from the task bar.



well, the fastest way to QuickLaunch is of course to have mozilla.exe already
running, just w/o any windows. I guess that's the current situation.

Maybe the "true" QuickLaunch needs a little mozilla helper app. that
automagically respawns Mozilla.exe if it is terminated in a crash?


confirming on build 2002021503 XP and Win2k
Status: UNCONFIRMED → NEW
Ever confirmed: true
I filed Bug 127122 on the helper app.
BTW - If that bug is fixed, this one still needs to be fixed.
using 2002030403 i now see the following:
QuickLaunch is enabled. I close all Mozilla windows, and kill the sys tray icon.

I start Mozilla (the browser) and the sys tray icon appears! So that seems a
partial fix (still Mozilla needs to respawn its process after a crash)

However, if i start Mozilla (the mail program) the sys tray icon does NOT appear.

Sorry, i didn't wanna file a new bug for this


This is the bug I filled as number 133220 (cf comment #13), just above mine :-)

It is really annoying ! Could it be fixed soon, please ?
I found a work around in order to get back quicklaunch icon in tray.

1. launch mozilla (quicklaunch enabled). if you have no tray icon, go to
preferences / advanced and uncheck quicklaunch. Click OK button.

2. Go again to go to preferences / advanced and check quicklaunch. Now, tray
icon should appear.

But having this bug fixed is more useful :-)
*** Bug 133220 has been marked as a duplicate of this bug. ***
Why target 1.1alpha ? Should not get fixed before ?! :-(
Frederic: This is on my to-do list.
Ok ! Thanks. I would prefer not using the /workaround/ I explained before :-)
FYI - this sounds familiar to bug 133120, which had a checkin last week (or will
soon).  Check say it's fixed if you reset the Quicklaunch option in Preferences,
which I'll test after submitting this comment!

nominating and adding to tracking bug.
Blocks: 108785
Keywords: nsbeta1
nsbeta1+/adt2 per Nav triage team, 1.0
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt2]
Target Milestone: mozilla1.1alpha → mozilla1.0
I've been seeing this problem too on both my WinNT and Win2K machines.  The
workaround mentioned here does indeed bring my QuickLaunch icon back to the
taskbar...but only until I mouseover it.  As soon as I mouseover, it disappears
again and the netscp6.exe continues to run in the background...which isn't a
good thing.  

I see this behavior with today's 2002041113 MozillaTrunk build on both WinNT and
Win2K.
the  mouseover problem is bug 136181
I'm not sure what the relationship is between this bug and bug 133120, but I do
want to clarify one thing.

When you load Mozilla.exe with the -turbo command-line option it's only supposed
to load the QuickLaunch module, right?  This is the command in the Windows
Registry (HKCU).  If you load it a second time with the option, then the browser
window launches, which is fine with me.

What doesn't seem to be happening is that loading Mozilla.exe without the
command-line option should also load the Quicklaunch (and display the Systray
icon), but it doesn't do it unless you go into Edit / Preferences / Advanced and
confirm that QuickLaunch is checked-marked.
Blocks: 108795
No longer blocks: 108785
Whiteboard: [adt2] → [adt2 rtm]
How do you force a crash, i.e., to test this?

At this point, my understanding of this bug is that Mozilla does not correctly
detect the "remains" of QuickLaunch after a crash.  If correct, I would suggest
we (really, the reporter!) change the summary to something like "Quicklaunch
fails to reload after crash".  This would more clearly differentiate it from bug
133120.

In answer to comment #26 :

quicklaunch is working after a crash... Experienced it some days ago, verifying
a bug I do not remember.
I think this bug also triggered bug 133120.

Changing summary according to comment 26. I hope this one's better? 

I also wanted to change platform to ALL WINDOWS VERSIONS, only to find there's
no such thing listed.
Summary: quick launch not enabled after crash, even when box is checked → quick launch (turbo) not persistent during crash ( fails to reload after crash)
Tony: End task Mozilla in task mangager and it will simulate a crash.
Patrick: ALL WIN32 bug 12309
removing plus for re-triage, this seems too low benefit/high risk for this late
in machV
Keywords: nsbeta1+ → nsbeta1
WFM with build 2002-05-01-branch on WinNT.

I had to wait for them to fix bug 133120 but I'm (still) not seeing this
problem. I have Mozilla installed as browser-only, Quicklaunch active.  I use
NT's taskmgr to End Process on mozilla.exe.  The Quicklaunch icon remains (but
disappears if you point at it).  Reloading Mozilla results in a 2nd Quicklaunch
icon which works properly.

Did the changes for bug 133120 fix this bug, too?
nsbeta1- per Nav triage team, ->1.1
Keywords: nsbeta1 → nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.1alpha
*** Bug 145788 has been marked as a duplicate of this bug. ***
Is the BUG:
http://bugzilla.mozilla.org/show_bug.cgi?id=103786
(quick launch does not recover from exit, crash, etc)
the same as this one?
Indeed it is, and that other bug is incorrectly resolved WFM.
Patrick: Can you please do some testing to see if the problem exists anymore?

This bug does still happen doesn't it? I haven't checked lately, but I think due
to the similiarities that bug 133120 might have fixed it.
Otherwise, this bug should probably be marked FIXED.
No longer blocks: 108795
The issue seems to be this:

If QuickLaunch is enabled and running and:
- you close it by: RightClick->Exit
- you kill it via taskmanager
- it crash
the next time(in the same Windows session) you start Mozilla,
QuickLaunch will not be started.
QuickLaunch will be started only after you:
- restart windows
- restart you windows session
- uncheck and check again the checkbutton in the Preference window
  for Quicklaunch

I think there are at least 2 bugs that are the same as the above 
description. Should be unite all similar bugs? Are they related?


That is different from the bug reported here.  Grace, have you seen what Oliver
reports here?
testing with both trunk and branch builds for 5/23 I am not seeing this bug
anymore- crash and relaunch and icon shows in systray !!!!

I am also not seeing what Oliver sees in comment #39 with either of these
builds.  After exiting via icon or task manager, next launch puts icon in
systray- no reboot necessary

this worksforme
resolving as wfm
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
verified
Status: RESOLVED → VERIFIED
*** Bug 219653 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.