1211033 - Unexpected error during validation

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Serge Lebedev]

Attachment: [e-mail]

> Whether this error occurred during the submission of a new add-on, a new version of an existing add-on, a new file in an existing version, or an upload to the standalone validator.

Tried all of it.

> Whether your add-on is listed or unlisted.

Unlisted.

> The URL where you submitted the add-on.

https://addons-dev.allizom.org/en-US/developers/addon/submit/2

> The approximate time you submitted the add-on, with timezone.

2015-10-03 06:00 UTC+6

Couldn't validate the attached add-on file neither on stable https://addons.mozilla.org/, nor on stage server https://addons.allizom.org/, nor on dev server https://addons-dev.allizom.org.

Comment 1

[Mathieu Agopian [:magopian]]

Is this linked to https://bugzilla.mozilla.org/show_bug.cgi?id=1208964 ? It's both for issues with an add-on named "godville".

Comment 2

[Serge Lebedev]

(In reply to Mathieu Agopian [:magopian] from comment #1)
> Is this linked to https://bugzilla.mozilla.org/show_bug.cgi?id=1208964 ?
> It's both for issues with an add-on named "godville".

That add-on (maintained by another developer) was forked from my add-on. That's the only relation they have. So I guess that bug isn't linked to this.

Comment 3

[Mathieu Agopian [:magopian]]

We pushed some changes to production, could you please give it another try, and close this bug if it's fixed? Thanks!

Comment 4

[Serge Lebedev]

Attachment: Minimal testcase for auto-validation to fail

(In reply to Mathieu Agopian [:magopian] from comment #3)
> We pushed some changes to production, could you please give it another try,
> and close this bug if it's fixed? Thanks!

My add-on still fails to get validated. But I did a little research and discovered a minimal testcase for validation to fail.

It's the add-on that merely concatenates 465 empty strings.

Comment 5

[Serge Lebedev]

Attachment: Minimal testcase for auto-validation to pass

But the same add-on that concatenates only 464 empty strings passes the validation.

I checked for a couple of times, seems like the bug can be reproduced with my testcased add-ons.

Comment 6

[Mathieu Agopian [:magopian]]

Thanks a lot for the investigation and the minimal testcase!

:mstriemer, another one for you if you have the time ;)

Comment 7

[Serge Lebedev]

And I believe that this bug is a regression bug. Old versions of my add-on, that were validated some time ago, now cause unexpected error.

I suspect that's because of the same 'concatenate-too-many-strings-and-variables' bug, that I have attached testcases for.

Comment 8

[Serge Lebedev]

My add-on passed the validated successfully today, so it seems like this bug is fixed. Thanks.