Closed
Bug 121105
Opened 24 years ago
Closed 24 years ago
<script type="application/x-javascript"> seems to confuse IE
Categories
(Webtools Graveyard :: Bonsai, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jacob, Assigned: timeless)
References
()
Details
Attachments
(1 file, 2 obsolete files)
|
6.35 KB,
patch
|
jacob
:
review+
|
Details | Diff | Splinter Review |
Revision 1.26 of cvsblame.cgi contains the addition of:
type="application/x-javascript"
in the <script> tag at line 527. This seems to confuse IE 6 as when that
exists, IE raises a script error every time the mouse is hovered over a link.
Upon removing that and making it just <script>, IE does what it's supposed to
and displays the <div> w/checkin information.
|
Reporter | |
Comment 1•24 years ago
|
||
Use the same code that determines wheter or not we can use the DOM stuff to
determine which JavaScript tag to send down.
we should probably send language= for Mozilla/X for all X<4
Assignee: tara → timeless
|
|
Reporter | |
Comment 4•24 years ago
|
||
$::script_type, $::use_dom, and $::use_layers were added in bug 123339.
Attachment #67905 -
Attachment is obsolete: true
|
||
Comment 5•24 years ago
|
||
Comment on attachment 69105 [details] [diff] [review]
Patch v2 - Use the new global variables
>-print " onmouseover='return log(event,\"$::prev_revision{$revision}\",\"$revision\");'" if $use_layers;
>-print " onmouseover=\"showMessage('$revision','top')\" id=\"line_top\"" if $use_dom;
>+print " onmouseover='return log(event,\"$::prev_revision{$revision}\",\"$revision\");'" if $::use_layers;
>+print " onmouseover=\"showMessage('$revision','top')\" id=\"line_top\"" if $::use_dom;
Why are we changing from log to showmessage here?
>Index: cvsview2.cgi
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bonsai/cvsview2.cgi,v
>retrieving revision 1.24
>diff -u -r1.24 cvsview2.cgi
>--- cvsview2.cgi 1 Feb 2002 14:32:55 -0000 1.24
>+++ cvsview2.cgi 12 Feb 2002 21:43:05 -0000
>@@ -479,7 +479,7 @@
>
> print qq%
> <HEAD>
>- <SCRIPT type="application/x-javascript"><!--
>+ <SCRIPT $::sciprt_type><!--
s/sciprt/script/
r=kiko with that fixed.
Attachment #69105 -
Flags: needs-work+
|
|
Reporter | |
Comment 6•24 years ago
|
||
> Why are we changing from log to showmessage here?
We aren't, there's one of each [log() for layers and showMessage() for DOM]
> s/sciprt/script/
Oops, fixed.
I'll assume the r=kiko is valid as all I changed is the typo.
|
|
Reporter | |
Updated•24 years ago
|
Attachment #69232 -
Flags: review+
|
|
Reporter | |
Updated•24 years ago
|
Attachment #69105 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 7•24 years ago
|
||
Checking in cvsblame.cgi;
/cvsroot/mozilla/webtools/bonsai/cvsblame.cgi,v <-- cvsblame.cgi
new revision: 1.29; previous revision: 1.28
done
Checking in cvsquery.cgi;
/cvsroot/mozilla/webtools/bonsai/cvsquery.cgi,v <-- cvsquery.cgi
new revision: 1.31; previous revision: 1.30
done
Checking in cvsview2.cgi;
/cvsroot/mozilla/webtools/bonsai/cvsview2.cgi,v <-- cvsview2.cgi
new revision: 1.25; previous revision: 1.24
done
Checking in rview.cgi;
/cvsroot/mozilla/webtools/bonsai/rview.cgi,v <-- rview.cgi
new revision: 1.16; previous revision: 1.15
done
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•