Amount of streams per data channel ignores upper limit check

RESOLVED FIXED in Firefox 43

Status

()

defect
P2
normal
Rank:
25
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox41 affected, firefox42 affected, firefox43 fixed, firefox44 fixed)

Details

Attachments

(1 attachment)

No description provided.
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
Bug 1211091: use upper boundary for streams per data channel. r?bwc
Attachment #8669265 - Flags: review?(docfaraday)
https://reviewboard.mozilla.org/r/21179/#review19045

I probably should add a unit test.
See Also: → 1211097
(In reply to Nils Ohlmeier [:drno] from comment #3)
> https://reviewboard.mozilla.org/r/21179/#review19045
> 
> I probably should add a unit test.

A test would only work if bug 1211097 gets fixed. So it is probably easier to just ship this here and ship the test with bug 1211097.
Comment on attachment 8669265 [details]
MozReview Request: Bug 1211091: use upper boundary for streams per data channel. r?bwc

https://reviewboard.mozilla.org/r/21179/#review19123
Attachment #8669265 - Flags: review?(docfaraday) → review+
green try
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f90a12394a06
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8669265 [details]
MozReview Request: Bug 1211091: use upper boundary for streams per data channel. r?bwc

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Some confusion for apps trying to use a large number of datachannels in an interop (Chrome or datachannel-enabled server) situation.

[Describe test coverage new/current, TreeHerder]: hand tested

[Risks and why]: Almost no risk; trivial patch, baking for some time.

[String/UUID change made/needed]: None.
Attachment #8669265 - Flags: approval-mozilla-aurora?
Comment on attachment 8669265 [details]
MozReview Request: Bug 1211091: use upper boundary for streams per data channel. r?bwc

OK to uplift, looks ok on m-c and had manual testing.
Attachment #8669265 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.