1211092 - Intermittent e10s browser_bookmarksProperties.js | EditItemOverlay is initialized and more

Reporter

Description

•

9 years ago

https://treeherder.mozilla.org/logviewer.html#?job_id=15139436&repo=mozilla-inbound

 20:31:13     INFO -  81 INFO TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmarksProperties.js | EditItemOverlay is initialized -
 20:31:13     INFO -  Stack trace:
 20:31:13     INFO -  chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:open_properties_dialog/windowObserver/</<:412
 20:31:13     INFO -  chrome://mochikit/content/browser-test.js:testScope/test_executeSoon/<.run:966
 20:31:13     INFO -  resource:///modules/PlacesUIUtils.jsm:PUIU_showBookmarkDialog:476
 20:31:13     INFO -  chrome://browser/content/places/controller.js:PC_doCommand:293
 20:31:13     INFO -  chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:open_properties_dialog:449
 20:31:13     INFO -  chrome://mochikit/content/browser-test.js:testScope/test_executeSoon/<.run:966
 20:31:13     INFO -  null:null:0
 20:31:13     INFO -  ASSERT: Invalid menuitem in the folders-menulist
 20:31:13     INFO -  Stack Trace:
 20:31:13     INFO -  0:_getFolderIdFromMenuList()
 20:31:13     INFO -  1:toggleFolderTreeVisibility()
 20:31:13     INFO -  2:oncommand([object XULCommandEvent])
 20:31:13     INFO -  82 INFO Console message: [JavaScript Warning: "Use of Mutation Events is deprecated. Use MutationObserver instead." {file: "resource://gre/modules/RemoteAddonsParent.jsm" line: 624}]
 20:31:13     INFO -  JavaScript error: resource://gre/modules/debug.js, line 74: TypeError: access to strict mode caller function is censored
 20:31:13     INFO -  JavaScript error: resource://gre/modules/debug.js, line 74: TypeError: access to strict mode caller function is censored
 20:31:13     INFO -  Not taking screenshot here: see the one that was previously logged
 20:31:13     INFO -  83 INFO TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmarksProperties.js | We are editing new folder name in folder tree -
 20:31:13     INFO -  Stack trace:
 20:31:13     INFO -  chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:.run/onDOMAttrModified/<:304
 20:31:13     INFO -  chrome://mochikit/content/browser-test.js:testScope/test_executeSoon/<.run:966
 20:31:13     INFO -  resource:///modules/PlacesUIUtils.jsm:PUIU_showBookmarkDialog:476
 20:31:13     INFO -  chrome://browser/content/places/controller.js:PC_doCommand:293
 20:31:13     INFO -  chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:open_properties_dialog:449
 20:31:13     INFO -  chrome://mochikit/content/browser-test.js:testScope/test_executeSoon/<.run:966
 20:31:13     INFO -  null:null:0
 20:31:13     INFO -  84 INFO TEST-PASS | browser/components/places/tests/browser/browser_bookmarksProperties.js | We have finished editing folder name in folder tree -
 20:31:13     INFO -  JavaScript error: resource://gre/modules/PlacesUtils.jsm, line 3254: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.setItemTitle]
 20:31:13     INFO -  JavaScript error: resource://gre/modules/PlacesUtils.jsm, line 3254: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.setItemTitle]
 20:31:13     INFO -  JavaScript error: resource://gre/modules/PlacesUtils.jsm, line 3254: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.setItemTitle]
 20:31:13     INFO -  Not taking screenshot here: see the one that was previously logged
 20:31:13     INFO -  85 INFO TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmarksProperties.js | uncaught exception - NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.undoTransaction] at chrome://browser/content/places/bookmarkProperties.js:455
 20:31:13     INFO -  Stack trace:
 20:31:13     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1517
 20:31:13     INFO -  resource:///modules/PlacesUIUtils.jsm:PUIU_showBookmarkDialog:476
 20:31:13     INFO -  chrome://browser/content/places/controller.js:PC_doCommand:293
 20:31:13     INFO -  chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:open_properties_dialog:449
 20:31:13     INFO -  chrome://mochikit/content/browser-test.js:testScope/test_executeSoon/<.run:966
 20:31:13     INFO -  null:null:0
 20:31:13     INFO -  JavaScript error: chrome://browser/content/places/bookmarkProperties.js, line 455: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.undoTransaction]
 20:31:13     INFO -  86 INFO Console message: [JavaScript Error: "ASSERT: Invalid menuitem in the folders-menulist
 20:31:13     INFO -  " {file: "resource://gre/modules/debug.js" line: 54}]
 20:31:13     INFO -  87 INFO Console message: [JavaScript Error: "ASSERT: Invalid menuitem in the folders-menulist
 20:31:13     INFO -  " {file: "resource://gre/modules/debug.js" line: 54}]
 20:31:13     INFO -  88 INFO Console message: [JavaScript Error: "TypeError: access to strict mode caller function is censored" {file: "resource://gre/modules/debug.js" line: 74}]
 20:31:13     INFO -  NS_ASSERT@resource://gre/modules/debug.js:74:7
 20:31:13     INFO -  _getFolderIdFromMenuList@chrome://browser/content/places/editBookmarkOverlay.js:675:1
 20:31:13     INFO -  onFolderTreeSelect@chrome://browser/content/places/editBookmarkOverlay.js:768:9
 20:31:13     INFO -  onselect@chrome://browser/content/places/bookmarkProperties2.xul:1:1
 20:31:13     INFO -  selectItems@chrome://browser/content/places/tree.xml:671:11
 20:31:13     INFO -  gEditItemOverlay.newFolder<@chrome://browser/content/places/editBookmarkOverlay.js:935:1
 20:31:13     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:314:40
 20:31:13     INFO -  TaskImpl@resource://gre/modules/Task.jsm:275:3
 20:31:13     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
 20:31:13     INFO -  oncommand@chrome://browser/content/places/bookmarkProperties2.xul:1:1
 20:31:13     INFO -  .run/onDOMAttrModified/<@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:303:9
 20:31:13     INFO -  testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:966:9
 20:31:13     INFO -  PUIU_showBookmarkDialog@resource:///modules/PlacesUIUtils.jsm:476:5
 20:31:13     INFO -  PC_doCommand@chrome://browser/content/places/controller.js:293:1
 20:31:13     INFO -  open_properties_dialog@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:449:5
 20:31:13     INFO -  testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:966:9
 20:31:13     INFO -  89 INFO Console message: [JavaScript Error: "ASSERT: Invalid menuitem in the folders-menulist
 20:31:13     INFO -  " {file: "resource://gre/modules/debug.js" line: 54}]
 20:31:13     INFO -  90 INFO Console message: [JavaScript Error: "TypeError: access to strict mode caller function is censored" {file: "resource://gre/modules/debug.js" line: 74}]
 20:31:13     INFO -  NS_ASSERT@resource://gre/modules/debug.js:74:7
 20:31:13     INFO -  _getFolderIdFromMenuList@chrome://browser/content/places/editBookmarkOverlay.js:675:1
 20:31:13     INFO -  onFolderTreeSelect@chrome://browser/content/places/editBookmarkOverlay.js:768:9
 20:31:13     INFO -  onselect@chrome://browser/content/places/bookmarkProperties2.xul:1:1
 20:31:13     INFO -  PTV_invalidateContainer@chrome://browser/content/places/treeView.js:1008:5
 20:31:13     INFO -  PTV_containerStateChanged@chrome://browser/content/places/treeView.js:877:5
 20:31:13     INFO -  gEditItemOverlay.newFolder<@chrome://browser/content/places/editBookmarkOverlay.js:936:5
 20:31:13     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:314:40
 20:31:13     INFO -  TaskImpl@resource://gre/modules/Task.jsm:275:3
 20:31:13     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
 20:31:13     INFO -  oncommand@chrome://browser/content/places/bookmarkProperties2.xul:1:1
 20:31:13     INFO -  .run/onDOMAttrModified/<@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:303:9
 20:31:13     INFO -  testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:966:9
 20:31:13     INFO -  PUIU_showBookmarkDialog@resource:///modules/PlacesUIUtils.jsm:476:5
 20:31:13     INFO -  PC_doCommand@chrome://browser/content/places/controller.js:293:1
 20:31:13     INFO -  open_properties_dialog@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:449:5
 20:31:13     INFO -  testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:966:9
 20:31:13     INFO -  91 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.setItemTitle]" {file: "resource://gre/modules/PlacesUtils.jsm" line: 3254}]
 20:31:13     INFO -  92 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.setItemTitle]" {file: "resource://gre/modules/PlacesUtils.jsm" line: 3254}]
 20:31:13     INFO -  93 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.setItemTitle]" {file: "resource://gre/modules/PlacesUtils.jsm" line: 3254}]
 20:31:13     INFO -  94 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.undoTransaction]" {file: "chrome://browser/content/places/bookmarkProperties.js" line: 455}]
 20:31:13     INFO -  95 INFO TEST-PASS | browser/components/places/tests/browser/browser_bookmarksProperties.js | Dialog window should not be closed by pressing ESC in folder name textbox -
 20:31:13     INFO -  96 INFO End of test:  Bug 491269 - Test that editing folder name in bookmarks properties dialog does not accept the dialog
 20:31:13     INFO -  Not taking screenshot here: see the one that was previously logged
 20:31:13     INFO -  97 INFO TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmarksProperties.js | A promise chain failed to handle a rejection:  - at resource://gre/modules/PlacesUtils.jsm:2429 - Error: no item found for the given GUID
 20:31:13     INFO -  Stack trace:
 20:31:13     INFO -      GuidHelper.getItemId</itemId<@resource://gre/modules/PlacesUtils.jsm:2429:1
 20:31:13     INFO -      ConnectionData.prototype<.executeBeforeShutdown@resource://gre/modules/Sqlite.jsm:376:25
 20:31:13     INFO -      OpenedConnection.prototype<.executeBeforeShutdown@resource://gre/modules/Sqlite.jsm:1228:12
 20:31:13     INFO -      this.PlacesUtils.withConnectionWrapper/<@resource://gre/modules/PlacesUtils.jsm:1425:14
 20:31:13     INFO -      ConnectionData.prototype<.executeBeforeShutdown@resource://gre/modules/Sqlite.jsm:386:1
 20:31:13     INFO -      OpenedConnection.prototype<.executeBeforeShutdown@resource://gre/modules/Sqlite.jsm:1228:12
 20:31:13     INFO -      this.PlacesUtils.withConnectionWrapper/<@resource://gre/modules/PlacesUtils.jsm:1425:14
 20:31:13     INFO -      promiseItemId@resource://gre/modules/PlacesUtils.jsm:1687:12
 20:31:13     INFO -      BookmarkPropertiesPanel._createNewItem<@chrome://browser/content/places/bookmarkProperties.js:612:26
 20:31:13     INFO -      BookmarkPropertiesPanel._promiseNewItem<@chrome://browser/content/places/bookmarkProperties.js:627:14
 20:31:13     INFO -      onload@chrome://browser/content/places/bookmarkProperties2.xul:1:1
 20:31:13     INFO -      PUIU_showBookmarkDialog@resource:///modules/PlacesUIUtils.jsm:476:5
 20:31:13     INFO -      PC_doCommand@chrome://browser/content/places/controller.js:293:1
 20:31:13     INFO -      open_properties_dialog@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js:449:5
 20:31:13     INFO -      testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:966:9
 20:31:13     INFO -      testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1064:11
 20:31:13     INFO -      testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:966:9
 20:31:13     INFO -  MEMORY STAT | vsize 3845MB | residentFast 412MB | heapAllocated 150MB
 20:31:13     INFO -  98 INFO TEST-OK | browser/components/places/tests/browser/browser_bookmarksProperties.js | took 2882ms
 20:31:13     INFO -  99 INFO TEST-START | browser/components/places/tests/browser/browser_forgetthissite_single.js

Tracy Walker [:tracy]

Updated

•

9 years ago

Blocks: e10s-tests

tracking-e10s: --- → +

Chris Peterson [:cpeterson]

Comment 1

•

8 years ago

Intermittent e10s test failure

Priority: -- → P5

Comment hidden (Intermittent Failures Robot)

7 failures in 883 pushes (0.008 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 6
* autoland: 1

Platform breakdown:
* windows8-64: 4
* windows7-32-vm: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-04-24&endday=2017-04-30&tree=all

Comment hidden (Intermittent Failures Robot)

1 failures in 814 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-06-12&endday=2017-06-18&tree=all

Comment hidden (Intermittent Failures Robot)

13 failures in 892 pushes (0.015 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 7
* autoland: 4
* mozilla-central: 2

Platform breakdown:
* windows8-64: 11
* windows7-32-vm: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-06-19&endday=2017-06-25&tree=all

Comment hidden (Intermittent Failures Robot)

20 failures in 131 pushes (0.153 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 9
* autoland: 7
* mozilla-central: 4

Platform breakdown:
* windows8-64: 20

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-06-27&endday=2017-06-27&tree=all

Geoff Brown [:gbrown]

Comment 6

•

7 years ago

:mak - This test has been failing infrequently for a long time. Beginning around June 25, it is failing frequently, almost always on Windows 8. Can you find someone to look into it?

Flags: needinfo?(mak77)

Whiteboard: [stockwell needswork]

Mark Banner (:standard8)

Assignee

Comment 7

•

7 years ago

I'm working on fixes for some async items in bug 1376925. They should fix this.

Assignee: nobody → standard8

Depends on: 1376925

Flags: needinfo?(mak77)

Comment hidden (Intermittent Failures Robot)

20 failures in 193 pushes (0.104 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 12
* mozilla-inbound: 6
* mozilla-central: 2

Platform breakdown:
* windows8-64: 20

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-06-29&endday=2017-06-29&tree=all

Comment hidden (Intermittent Failures Robot)

16 failures in 147 pushes (0.109 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 11
* autoland: 3
* oak: 1
* mozilla-central: 1

Platform breakdown:
* windows8-64: 15
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-06-30&endday=2017-06-30&tree=all

Comment hidden (Intermittent Failures Robot)

124 failures in 718 pushes (0.173 failures/push) were associated with this bug in the last 7 days. 

This is the #4 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 50
* mozilla-inbound: 47
* mozilla-central: 26
* oak: 1

Platform breakdown:
* windows8-64: 123
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-06-26&endday=2017-07-02&tree=all

Carsten Book [:Tomcat]

Comment 11

•

7 years ago

Mark, can the fix for bug 1376925 land now to fix this frequent intermittent ?

Flags: needinfo?(standard8)

Mark Banner (:standard8)

Assignee

Comment 12

•

7 years ago

(In reply to Carsten Book [:Tomcat] from comment #11)
> Mark, can the fix for bug 1376925 land now to fix this frequent intermittent
> ?

Unfortunately that bug isn't ready to land yet as there's still a few issues with it (we've been testing on try). However, I think I can separate out what I believe will fix this issue.

Flags: needinfo?(standard8)

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/153996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153996/

Mark Banner (:standard8)

Assignee

Comment 14

•

7 years ago

I've pushed this to try server via mozreview to give the tests a run as well.

Marco Bonardo [:mak]

Comment 15

•

7 years ago

mozreview-review

Comment on attachment 8883036 [details]
Bug 1211092 - Wait for the editItemOverlay to be initialised before continuing with browser_bookmarksProperties.js to avoid intermittents.

https://reviewboard.mozilla.org/r/153996/#review159126

::: browser/components/places/tests/browser/browser_bookmarksProperties.js:405
(Diff revision 1)
>        let observerWindow = aSubject.QueryInterface(Ci.nsIDOMWindow);
>        waitForFocus(() => {
>          // Windows has been loaded, execute our test now.
> -        executeSoon(function() {
> +        executeSoon(async function() {
>            // Ensure overlay is loaded
> -          ok(observerWindow.gEditItemOverlay.initialized, "EditItemOverlay is initialized");
> +          await BrowserTestUtils.waitForCondition(

I suspect the executeSoon was trying to do this, so we could probably remove it and only keep the waitForCondition?

Attachment #8883036 - Flags: review?(mak77) → review+

Comment hidden (mozreview-request)

Comment on attachment 8883036 [details]
Bug 1211092 - Wait for the editItemOverlay to be initialised before continuing with browser_bookmarksProperties.js to avoid intermittents.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153996/diff/1-2/

Comment hidden (Intermittent Failures Robot)

17 failures in 60 pushes (0.283 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 9
* autoland: 7
* mozilla-central: 1

Platform breakdown:
* windows8-64: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-07-03&endday=2017-07-03&tree=all

Mark Banner (:standard8)

Assignee

Comment 18

•

7 years ago

Try server looks good after a few respins, so I'll push this.

Pulsebot

Comment 19

•

7 years ago

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac2b7b047c0c
Wait for the editItemOverlay to be initialised before continuing with browser_bookmarksProperties.js to avoid intermittents. r=mak

Phil Ringnalda (:philor)

Reporter

Comment 20

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ac2b7b047c0c

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox56: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 56

Geoff Brown [:gbrown]

Updated

•

7 years ago

Whiteboard: [stockwell needswork] → [stockwell fixed]

Geoff Brown [:gbrown]

Updated

•

7 years ago

Whiteboard: [stockwell fixed] → [stockwell fixed:race]

Comment hidden (Intermittent Failures Robot)

34 failures in 656 pushes (0.052 failures/push) were associated with this bug in the last 7 days.   

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 20
* autoland: 9
* mozilla-central: 5

Platform breakdown:
* windows8-64: 34

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1211092&startday=2017-07-03&endday=2017-07-09&tree=all

Ryan VanderMeulen [:RyanVM]

Updated

•

7 years ago

status-firefox44: affected → ---

status-firefox54: --- → wontfix

status-firefox55: --- → affected

status-firefox-esr52: --- → wontfix

Ryan VanderMeulen [:RyanVM]

Comment 22

•

7 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/28f6161b9076

status-firefox55: affected → fixed

Flags: in-testsuite+