Also build busybox on sony-aosp-l devices

RESOLVED FIXED in FxOS-S9 (16Oct)

Status

Firefox OS
GonkIntegration
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: adfad666, Unassigned)

Tracking

unspecified
FxOS-S9 (16Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

45 bytes, text/x-github-pull-request
dhylands
: review+
Details | Review | Splinter Review
52 bytes, text/x-github-pull-request
dhylands
: review+
Details | Review | Splinter Review
62 bytes, text/x-github-pull-request
dhylands
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36
(Reporter)

Comment 1

3 years ago
Created attachment 8669303 [details] [review]
init_sh PR
Attachment #8669303 - Flags: review?(lissyx+mozillians)
(Reporter)

Updated

3 years ago
Summary: rename prebuilt busybox to prevent conflict with busybox repo if present → Also build busybox on sony-aosp-l devices
(Reporter)

Updated

3 years ago
Attachment #8669303 - Flags: review?(lissyx+mozillians) → review?(dhylands)
(Reporter)

Comment 2

3 years ago
Created attachment 8669311 [details] [review]
Manifest PR
Attachment #8669311 - Flags: review?(dhylands)
(Reporter)

Comment 3

3 years ago
Dave, can you also make a sony-aosp-l branch on android_external_busybox from the existing cm-12.1 branch please!

It's needed for your minimal busybox patch.

https://github.com/AdFad666/android_external_busybox/commit/b4eb71196e89503f2a65068d5ce700b1d8611379
Flags: needinfo?(dhylands)
(Reporter)

Updated

3 years ago
Blocks: 1209096
Comment on attachment 8669303 [details] [review]
init_sh PR

Thanks for following through with this. I was planning on finishing it up but got distracted with other things.
Flags: needinfo?(dhylands)
Attachment #8669303 - Flags: review?(dhylands) → review+
Attachment #8669311 - Flags: review?(dhylands) → review+
(In reply to Adam Farden from comment #3)
> Dave, can you also make a sony-aosp-l branch on android_external_busybox
> from the existing cm-12.1 branch please!
> 
> It's needed for your minimal busybox patch.
> 
> https://github.com/AdFad666/android_external_busybox/commit/
> b4eb71196e89503f2a65068d5ce700b1d8611379

I created a sony-aosp-l branch which matches with cm-12.1 (and coincidentally also cm-12.0). So sm-12.0, cm-12.1, and sony-aosp-l currently all point to e04727a3d94b99bfa3f23b79b60f95bebe030b0f
(Reporter)

Comment 6

3 years ago
Created attachment 8672036 [details] [review]
Busybox PR
Attachment #8672036 - Flags: review?(dhylands)
(Reporter)

Comment 7

3 years ago
Ready to merge!
Attachment #8672036 - Flags: review?(dhylands) → review+
(Reporter)

Updated

3 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.