1211147 - [gui] allow to use debug builds in the gui

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

So, this is basically adding a checkbox (or maybe better a combobox) to let the user choose the build type (e.g. debug only for now) where it make sense in the wizard.

See bug 1211138 comment 0 to see where that make sense.

Comment 1

[MikeLing]

hi Juilen, I would like to take it if it's ok(cause it looks like not to hard to applied).

Comment 2

[Julien Pagès (:parkouss)]

Yup, please go ahead !

Basically we have to add a combobox in the inbound wizard page. For each app, there is a list of possible values for the build-type (run "mozregression --list-build-types" to see them). This is what we need to provide
in the combobov values.

If that is not clear enough, please ask me.

Comment 3

[MikeLing]

 it tells me  AttributeError: type object 'FirefoxConfig' has no attribute 'BUILD_TYPES', https://pastebin.mozilla.org/8850398

Comment 4

[Julien Pagès (:parkouss)]

(In reply to MikeLing from comment #3)
>  it tells me  AttributeError: type object 'FirefoxConfig' has no attribute
> 'BUILD_TYPES', https://pastebin.mozilla.org/8850398

Hmm, it is hard to say something without having the code. Still FirefoxConfic inherit from CommonConfig, and CommonConfig defines BUILD_TYPES:

https://github.com/mozilla/mozregression/blob/master/mozregression/fetch_configs.py#L75

Are you sure you are on branch master, and up to date ?

Comment 5

[MikeLing]

Attachment: PR for bug 1211147

Comment 6

[Julien Pagès (:parkouss)]

Comment on attachment 8678716 [details] [review]
PR for bug 1211147

Thanks Mikeling!

There is a small issue and a nit, noted on the PR. Everything else is good, I tested the patch and it works fine.

Cool! Please tell me when you fixed the PR.

Comment 7

[Julien Pagès (:parkouss)]

Thanks! Landed in https://github.com/mozilla/mozregression/commit/40b34f3629a21009435c67b95473a330929aaff6.