Closed Bug 1211147 Opened 9 years ago Closed 9 years ago

[gui] allow to use debug builds in the gui

Categories

(Testing :: mozregression, defect)

defect
Not set
normal

Tracking

(firefox44 affected)

RESOLVED FIXED
Tracking Status
firefox44 --- affected

People

(Reporter: parkouss, Assigned: sabergeass)

References

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
parkouss
: review+
Details | Review
So, this is basically adding a checkbox (or maybe better a combobox) to let the user choose the build type (e.g. debug only for now) where it make sense in the wizard.

See bug 1211138 comment 0 to see where that make sense.
hi Juilen, I would like to take it if it's ok(cause it looks like not to hard to applied).
Yup, please go ahead !

Basically we have to add a combobox in the inbound wizard page. For each app, there is a list of possible values for the build-type (run "mozregression --list-build-types" to see them). This is what we need to provide
in the combobov values.

If that is not clear enough, please ask me.
Assignee: nobody → sabergeass
 it tells me  AttributeError: type object 'FirefoxConfig' has no attribute 'BUILD_TYPES', https://pastebin.mozilla.org/8850398
(In reply to MikeLing from comment #3)
>  it tells me  AttributeError: type object 'FirefoxConfig' has no attribute
> 'BUILD_TYPES', https://pastebin.mozilla.org/8850398

Hmm, it is hard to say something without having the code. Still FirefoxConfic inherit from CommonConfig, and CommonConfig defines BUILD_TYPES:

https://github.com/mozilla/mozregression/blob/master/mozregression/fetch_configs.py#L75

Are you sure you are on branch master, and up to date ?
Attached file PR for bug 1211147
Attachment #8678716 - Flags: review?(j.parkouss)
Comment on attachment 8678716 [details] [review]
PR for bug 1211147

Thanks Mikeling!

There is a small issue and a nit, noted on the PR. Everything else is good, I tested the patch and it works fine.

Cool! Please tell me when you fixed the PR.
Attachment #8678716 - Flags: review?(j.parkouss) → review+
Thanks! Landed in https://github.com/mozilla/mozregression/commit/40b34f3629a21009435c67b95473a330929aaff6.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: