121119 - Native widgets (Win2k) support for windowblinds (and others)

Status: RESOLVED WONTFIX

(Core Graveyard :: Skinability, enhancement)

Description

[Mox Soini]

After hearing about native styles in mozilla, I switched over to classic theme
and started hoping
my Win 2000 with Windowblinds (themed to look like Mac OSX :) would make mozilla
look like the rest of the environment.

However, so far not so good. The background color is whitish, as it is supposed
to be and the top window "frame" is mac style (as expected), but the mozilla
proper is showing plain classic theme (Win Build 2002011604 ).

The weird part is that while installing the build (using the
mozilla-win32-installer.exe), the buttons and listboxes etc. are showing the
OSX-theme (i.e. the buttons are blue and rounded).

I think the current way of native widgets does not support any other themeing
than with WinXP, since the dll used (uxtheme.dll) see
/gfx/src/windows/nsNativeThemeWin.cpp, line 139 
-- static const char kThemeLibraryName[] = "uxtheme.dll";

However, I'm quite convinced that adding support for windowblinds should not be
hard thing, because the installer works ok. Since I don't have C-compiler for
windows, I can't test it myself, but I wonder if changing the library name to
"USER32.DLL" or "COMCTL32.DLL" would do the trick...

for simple introduction, http://windowsxp.devx.com/articles/article2/default.asp

Thanks...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Over to hyatt.  Installer actually _uses_ native widgets -- it's a completely
native non-XUL application (has to be, mozilla is not yet installed at that
point).  So the fact that installer does it means nothing....

Comment 2

[Mox Soini]

Attachment: Screenshot showing the current situation with Windowblinds

Here's a screenshot showing the current situation. As you can see, none of the
widgets in mozilla are themed. (this is win2000 w/ windowblinds)

There's a funny "bug" in mozilla (appears also in Linux w/ GTK). In the actual
rendered page the scrollbar HTML-widget is themed accordingly (but nothing
else). This is not really about this bug though...

But, since the HTML-widget does appear themed, I think it must not be overly
difficult to make the rest of the widgets behave similarlly...

Comment 3

[scratch]

WB skins the new classic theme on WinXP, although with some skins things get
sized *really* oddly.  It seems that the minimum size for a button is the size
that the graphic used for it is.  Moz can scale that size up, but not down.  I
can post a screenshot if necessary.  This can be sort of fixed by actually
modifying the skin that's in use, but it seems to me that it's a bug in the
Mozilla theme implementation.  Should I file a new bug for this?

Comment 4

[Asa Dotzler [:asa]]

Mox, nsITheme is not planned to include support for win2K (or anything earlier
than winXP).